fix: change query to param to match endpoint format#183
Merged
Conversation
jmikros
changed the title
jmikros
changed the title
Alonza0314
approved these changes
Oct 29, 2025
Alonza0314
left a comment
Alonza0314
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. It’s correct that we should use c.Param() to get the supi, as defined in our OAM system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getOAMRoutes function under free5gc\NFs\amf\internal\sbi\api_oam.go, defines an endpoint "/registered-ue-context/:supi" where supi is expected to be treated as Param in go. Instead it is treated as Query in the HandleOAMRegisteredUEContext function, causing it to always return an array of all registered ue contexts.