Skip to content

fix(sbi/consumer): nil-check JsonData on UEContextTransfer 200 response #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alonza0314 merged 2 commits into from
Jun 10, 2026
Merged

fix(sbi/consumer): nil-check JsonData on UEContextTransfer 200 response #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee2b9c6
fix(sbi/consumer): nil-check JsonData on UEContextTransfer 200 response
SAY-5 May 6, 2026
8050843
fix(sbi/consumer): set problem detail before returning on missing Jso…
SAY-5 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/sbi/consumer/amf_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,12 @@ func (s *namfService) UEContextTransferRequest(
return ueContextTransferRspData, problemDetails, err
}
ueContextTransferRspData = res.UeContextTransferResponse200.JsonData
if ueContextTransferRspData == nil {
logger.ConsumerLog.Warnln("UeContextTransfer 200 response missing JsonData")
problemDetails = openapi.ProblemDetailsSystemFailure("invalid UE context transfer response: missing response data")
err = openapi.ReportError("UeContextTransfer 200 missing JsonData")

@Alonza0314 Alonza0314 May 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SAY-5 ,

I think it will be better to update the problem detail before the error return after we get in the nil error.

return ueContextTransferRspData, problemDetails, err
}
if ueContextTransferRspData.UeContext == nil {
problemDetails = openapi.ProblemDetailsSystemFailure("invalid UE context transfer response: missing UE context")
return ueContextTransferRspData, problemDetails, err
Expand Down
Loading