fix: IKEv2 IDi shall be random#24
Open
DomenicoVerde wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TS 33.501 Section 7.2.1 specifies that the UE shall set the ID initiator (IDi) payload to the ID_KEY_ID type in the first IKE_AUTH message, and that its value shall be an arbitrary random number. Currently, the
n3iwueuses the hardcoded string "UE" as the IDi value.This pull request updates the
n3iwueby replacing the hardcoded value with a randomly generated uint64, using the GenerateRandomNumber() function. The generated value is also stored in the n3ue internal context and used later for authentication.Validation
Tested with Free5GC v4.2.2 (commit eef1d0fe9867c245673d2e2345eeff79c48e04ef).