fix: handle case when no PCF is found in PCFSelection#219
Merged
Alonza0314 merged 1 commit intofree5gc:mainfrom May 6, 2026
Merged
fix: handle case when no PCF is found in PCFSelection#219Alonza0314 merged 1 commit intofree5gc:mainfrom
Alonza0314 merged 1 commit intofree5gc:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens SMF’s NRF consumer PCF discovery path by preventing a panic when NRF discovery returns no PCF instances (or a nil response), aligning PCF selection behavior with existing CHF selection handling.
Changes:
- Added a guard in
PCFSelectionto return a clear error when the NRF discovery response is nil or contains zero PCF instances. - Prevented potential out-of-bounds / nil dereference when assigning
SelectedPCFProfile.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@Alonza0314 LGTM |
Alonza0314
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing issue 1046
This pull request adds a safety check to the
PCFSelectionmethod innrf_service.goto handle cases where no PCF instances are found, preventing potential nil pointer errors.Error handling improvement:
resis nil or if there are no PCF instances found inres.SearchResult.NfInstanceswithin thePCFSelectionmethod ofnrf_service.go.