fix: correct typo in AdditionalQosFlows variable name#222
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a typo in the SMContext QoS flow map field name to improve readability and consistency across the context and NGAP/NAS builders.
Changes:
- Renamed
AdditonalQosFlowstoAdditionalQosFlowsonSMContext - Updated all shown call sites/builders/handlers to use the corrected field name
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/context/sm_context_policy.go | Updates QoS flow add/remove helpers to use the corrected map field name |
| internal/context/sm_context.go | Renames the SMContext struct field and initializes the corrected map in NewSMContext |
| internal/context/ngap_handler.go | Updates NGAP response handling to iterate/lookup the corrected QoS flow map |
| internal/context/ngap_build.go | Updates NGAP request builders to iterate the corrected QoS flow map |
| internal/context/gsm_build.go | Updates NAS (GSM) builder to iterate the corrected QoS flow map |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| AMBRQerMap map[uuid.UUID]uint32 | ||
| QerUpfMap map[string]uint32 | ||
| AdditonalQosFlows map[uint8]*QoSFlow // Key: qfi | ||
| AdditionalQosFlows map[uint8]*QoSFlow // Key: qfi |
Contributor
|
@Alonza0314 LGTM |
Alonza0314
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request corrects a consistent typo in the
SMContextstruct and related code, changing all instances of the field nameAdditonalQosFlowstoAdditionalQosFlows. This improves code readability and prevents potential bugs caused by inconsistent naming.