Skip to content

Conversation

@Ksound22
Copy link
Member

@Ksound22 Ksound22 commented Jan 28, 2026

Checklist:

Closes freeCodeCamp/CurriculumExpansion#1139

@Ksound22 Ksound22 marked this pull request as ready for review January 28, 2026 06:11
@Ksound22 Ksound22 marked this pull request as draft January 28, 2026 06:24
@Ksound22 Ksound22 changed the title Add basic express workshop feat(backend cert): add basic express workshop Jan 28, 2026
@Ksound22 Ksound22 marked this pull request as ready for review January 28, 2026 13:25
@ShaunSHamilton ShaunSHamilton self-assigned this Jan 29, 2026
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes below.

I will commit a fix to these.

Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just gone through the first few lessons with mostly API and pedagogy suggestions; I have not inspected the content much.


Main points:
a) Only test what the learning outcome needs - do not make the tests too specific
b) Layout and construct the lessons in such a way you can write more integration tests - use Tower or Babeliser as a last resort

It is common to use more of Babeliser during the first few lessons getting the Camper to set things up. After that, tests more similar to this should be common:

Comment on lines 60 to 62
const file = await __helpers.getFile("learn-express-by-building-a-random-joke-app", "server.js");
const code = new __helpers.Tower(file);
const expressVar = code.getVariable("express");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you find yourself doing the same thing repetedly in tests, move this to one of the before hooks. E.g. https://github.com/freeCodeCamp/solana-curriculum/blob/main/curriculum/locales/english/build-a-university-certification-nft.md#--before-all--

const randomJokeVar = handlerTower.getVariable("randomJoke");
assert.exists(randomJokeVar);

assert.match(randomJokeVar.compact, /(const|let|var)\s+randomJoke\s*=\s*jokes\[Math\.floor\(Math\.random\(\)\*jokes\.length\)\];?/);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should not check the code like this. Again, test what the lesson aims to teach - not a specific solution.

There are too many permutations of this kind of solution.

@ShaunSHamilton ShaunSHamilton changed the title feat(backend cert): add basic express workshop feat: add basic express workshop Jan 29, 2026
@ShaunSHamilton ShaunSHamilton changed the base branch from master to main January 29, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Basic Express Workshop

2 participants