fix: rename handleChallengeTemplateView to challengeTemplateView and …

…update related navigation
freeCodeCamp · Feb 27, 2025 · 2434183 · 2434183
1 parent d5b6d15
commit 2434183
Show file tree

Hide file tree

Showing 9 changed files with 34 additions and 35 deletions.
diff --git a/mobile-app/lib/app/app.dart b/mobile-app/lib/app/app.dart
@@ -16,7 +16,7 @@ import 'package:freecodecamp/service/dio_service.dart';
 import 'package:freecodecamp/service/news/api_service.dart';
 
 import 'package:freecodecamp/ui/views/code_radio/code_radio_view.dart';
-import 'package:freecodecamp/ui/views/learn/challenge/templates/template_handler_view.dart';
+import 'package:freecodecamp/ui/views/learn/challenge/templates/template_view.dart';
 import 'package:freecodecamp/ui/views/learn/landing/landing_view.dart';
 import 'package:freecodecamp/ui/views/learn/superblock/superblock_view.dart';
 import 'package:freecodecamp/ui/views/login/native_login_view.dart';
@@ -48,7 +48,7 @@ import 'package:stacked_services/stacked_services.dart';
     MaterialRoute(page: NewsAuthorView),
     MaterialRoute(page: NewsImageView),
     MaterialRoute(page: CodeRadioView),
-    MaterialRoute(page: HandleChallengeTemplateView),
+    MaterialRoute(page: ChallengeTemplateView),
     MaterialRoute(page: ProfileView),
     MaterialRoute(page: LearnLandingView, initial: true),
     MaterialRoute(page: NativeLoginView),

diff --git a/mobile-app/lib/app/app.router.dart b/mobile-app/lib/app/app.router.dart
diff --git a/mobile-app/lib/service/firebase/analytics_observer.dart b/mobile-app/lib/service/firebase/analytics_observer.dart
@@ -28,9 +28,9 @@ class AnalyticsObserver extends RouteObserver {
               route.settings.arguments as NewsBookmarkTutorialViewArguments;
           screenName += '/${routeArgs.tutorial.tutorialTitle}';
           break;
-        case HandleChallengeTemplateViewArguments:
+        case ChallengeTemplateViewArguments:
           final routeArgs =
-              route.settings.arguments as HandleChallengeTemplateViewArguments;
+              route.settings.arguments as ChallengeTemplateViewArguments;
           screenName += '/${routeArgs.challengeId}';
           break;
         default:

diff --git a/mobile-app/lib/service/learn/learn_service.dart b/mobile-app/lib/service/learn/learn_service.dart
@@ -173,8 +173,8 @@ class LearnService {
       _navigationService.back();
     } else {
       _navigationService.replaceWith(
-        Routes.handleChallengeTemplateView,
-        arguments: HandleChallengeTemplateViewArguments(
+        Routes.challengeTemplateView,
+        arguments: ChallengeTemplateViewArguments(
           challengeId: block.challengeTiles[challengeIndex + 1].id,
           block: block,
           challengesCompleted: challengesCompleted + 1,

diff --git a/mobile-app/lib/ui/views/learn/block/block_viewmodel.dart b/mobile-app/lib/ui/views/learn/block/block_viewmodel.dart
@@ -84,8 +84,8 @@ class BlockViewModel extends BaseViewModel {
 
   void routeToChallengeView(Block block, String challengeId) {
     _navigationService.navigateTo(
-      Routes.handleChallengeTemplateView,
-      arguments: HandleChallengeTemplateViewArguments(
+      Routes.challengeTemplateView,
+      arguments: ChallengeTemplateViewArguments(
         challengeId: challengeId,
         block: block,
         challengesCompleted: _challengesCompleted,

diff --git a/mobile-app/lib/ui/views/learn/challenge/challenge_viewmodel.dart b/mobile-app/lib/ui/views/learn/challenge/challenge_viewmodel.dart
@@ -461,8 +461,8 @@ class ChallengeViewModel extends BaseViewModel {
       await prefs.remove(challengeUrl);
 
       _navigationService.replaceWith(
-        Routes.handleChallengeTemplateView,
-        arguments: HandleChallengeTemplateViewArguments(
+        Routes.challengeTemplateView,
+        arguments: ChallengeTemplateViewArguments(
           block: block!,
           challengeId: currChallenge.id,
           challengesCompleted: challengesCompleted,

diff --git a/...enge/templates/template_handler_view.dart → ...rn/challenge/templates/template_view.dart b/...enge/templates/template_handler_view.dart → ...rn/challenge/templates/template_view.dart
@@ -6,11 +6,11 @@ import 'package:freecodecamp/ui/views/learn/challenge/templates/english/english_
 import 'package:freecodecamp/ui/views/learn/challenge/templates/multiple_choice/multiple_choice_view.dart';
 import 'package:freecodecamp/ui/views/learn/challenge/templates/python-project/python_project_view.dart';
 import 'package:freecodecamp/ui/views/learn/challenge/templates/python/python_view.dart';
-import 'package:freecodecamp/ui/views/learn/challenge/templates/template_handler_viewmodel.dart';
+import 'package:freecodecamp/ui/views/learn/challenge/templates/template_viewmodel.dart';
 import 'package:stacked/stacked.dart';
 
-class HandleChallengeTemplateView extends StatelessWidget {
-  const HandleChallengeTemplateView({
+class ChallengeTemplateView extends StatelessWidget {
+  const ChallengeTemplateView({
     Key? key,
     required this.block,
     required this.challengeId,
@@ -23,9 +23,9 @@ class HandleChallengeTemplateView extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    return ViewModelBuilder<HandleTemplateModel>.reactive(
+    return ViewModelBuilder<ChallengeTemplateViewModel>.reactive(
       onViewModelReady: (model) => model.initiate(block, challengeId),
-      viewModelBuilder: () => HandleTemplateModel(),
+      viewModelBuilder: () => ChallengeTemplateViewModel(),
       builder: (context, model, child) => FutureBuilder<Challenge?>(
         future: model.challenge,
         builder: (context, snapshot) {

diff --git a/...templates/template_handler_viewmodel.dart → ...allenge/templates/template_viewmodel.dart b/...templates/template_handler_viewmodel.dart → ...allenge/templates/template_viewmodel.dart
@@ -5,7 +5,7 @@ import 'package:freecodecamp/service/learn/learn_offline_service.dart';
 import 'package:freecodecamp/service/learn/learn_service.dart';
 import 'package:stacked/stacked.dart';
 
-class HandleTemplateModel extends BaseViewModel {
+class ChallengeTemplateViewModel extends BaseViewModel {
   Future<Challenge>? _challenge;
   Future<Challenge>? get challenge => _challenge;
 

diff --git a/mobile-app/lib/ui/views/learn/landing/landing_viewmodel.dart b/mobile-app/lib/ui/views/learn/landing/landing_viewmodel.dart
@@ -129,7 +129,7 @@ class LearnLandingViewModel extends BaseViewModel {
           hasInternet: true,
         );
 
-        _navigationService.navigateToHandleChallengeTemplateView(
+        _navigationService.navigateToChallengeTemplateView(
           block: block,
           challengesCompleted: completedChallenges,
           challengeId: challenge.id,