Skip to content

feat: add custom highlighting engine #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add custom highlighting engine #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3fe3ac
fix: update phone_ide dependency to use local path
Sembauke Jul 11, 2025
c87b068
fix: enable syntax highlighting for supported file types in Challenge…
Sembauke Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mobile-app/lib/ui/views/learn/challenge/challenge_viewmodel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,9 @@ class ChallengeViewModel extends BaseViewModel {
end: file.editableRegionBoundaries[1],
)
: null,
useHighlightJs: !['html', 'css', 'js'].contains(
file.ext.value.toLowerCase(),
),
fontFamily: 'Hack',
);

Expand Down
7 changes: 3 additions & 4 deletions mobile-app/pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,10 +1324,9 @@ packages:
phone_ide:
dependency: "direct main"
description:
name: phone_ide
sha256: a63447e2dda56ac52367edb2f6b1cc09d1e5b73c48478e7d4a53b26253e9ee5c
url: "https://pub.dev"
source: hosted
path: "../../phoneide"
relative: true
source: path
version: "2.0.0"
photo_view:
dependency: "direct main"
Expand Down
3 changes: 2 additions & 1 deletion mobile-app/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ dependencies:
just_audio: 0.10.2
path: 1.9.1
path_provider: 2.1.5
phone_ide: 2.0.0
phone_ide:
path: ../../phoneide
photo_view: 0.15.0
pretty_dio_logger: 1.4.0
quick_actions: 1.1.0
Expand Down
Loading