Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove probe-image, roll our own solution #1111

Merged
merged 3 commits into from
Mar 23, 2025

Conversation

scissorsneedfoodtoo
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo commented Mar 23, 2025

Checklist:

It seems like the probe-image-size package doesn't play nicely with recent versions of Piscina (used for multithreaded builds) if there are any errors.

For now, I think the best solution is for us to handle image dimension probing on our own. While this may introduce some flakiness with the tests and the final builds, where the width or height for images may return different values in some cases, it doesn't seem like a widespread problem.

If flakiness is an issue going forward, we can take another look at Piscina, and consider replacing it, and / or figure out a way to use the probe-image-size package again.

Copy link

socket-security bot commented Mar 23, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 379 kB netroy

🚮 Removed packages: npm/[email protected]

View full report↗︎

@scissorsneedfoodtoo scissorsneedfoodtoo force-pushed the fix/image-dimension-handling branch from 8608476 to 9fb9f9e Compare March 23, 2025 08:45
@scissorsneedfoodtoo scissorsneedfoodtoo marked this pull request as ready for review March 23, 2025 12:07
@scissorsneedfoodtoo scissorsneedfoodtoo requested a review from a team as a code owner March 23, 2025 12:07
@raisedadead raisedadead merged commit 698ca74 into main Mar 23, 2025
50 of 53 checks passed
@raisedadead raisedadead deleted the fix/image-dimension-handling branch March 23, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants