fix: remove probe-image, roll our own solution #1111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md
)It seems like the
probe-image-size
package doesn't play nicely with recent versions of Piscina (used for multithreaded builds) if there are any errors.For now, I think the best solution is for us to handle image dimension probing on our own. While this may introduce some flakiness with the tests and the final builds, where the width or height for images may return different values in some cases, it doesn't seem like a widespread problem.
If flakiness is an issue going forward, we can take another look at Piscina, and consider replacing it, and / or figure out a way to use the
probe-image-size
package again.