fix: move back to probe-image-size #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
scissorsneedfoodtoo
force-pushed
the
fix/move-back-to-probe-image-size
branch
3 times, most recently
from
f1ad9eb to
a46ebf7
Compare
scissorsneedfoodtoo
force-pushed
the
fix/move-back-to-probe-image-size
branch
from
cedeb67 to
2076b8f
Compare
raisedadead
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)probe-image-sizeis so much faster than any other solution I've been able to find, and should be ESM compatible in the future if we move in that direction, so it's best to go back to that.After a lot of digging, it seems like the issue is that the network requests it's making under the hood follow redirects, which don't result in the final image. Might have something to do with the redirect from https://www.freecodecamp.org/news/content/images/2023/08/Learn-Python-with-Code-Examples-Handbook-Cover--2-.png --> https://cdn-media-0.freecodecamp.org/2023/08/Learn-Python-with-Code-Examples-Handbook-Cover--2-.png, and Cloudflare not allowing hotlinking?
Either way, the main fix is to go down from the default max redirects of 10 to 0. This probably means that more images won't have proper dimensions, but that should be fixed once we move to a new platform and move all images to a CDN.