Skip to content

Conversation

@scissorsneedfoodtoo
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo commented Jan 29, 2026

Checklist:

Related to #1341

This PR fixes a couple of issues from major search overhaul in #1341:

  1. Searching other News indicies is fixed now that we're setting the index dynamically during the build with {{ secrets.algoliaIndex }}
  2. The search results page has been updated for Algolia v5 as well, which I forgot to check for in the last PR

However, I've had to disable most of the e2e tests for the search results page temporarily. While the tests all pass locally, there's some issue with them running via GH Actions.

I'll try to find a fix if necessary and reenable them in a future PR.

@scissorsneedfoodtoo scissorsneedfoodtoo force-pushed the fix/search-page-and-localized-search-results branch from 428d340 to 70ce344 Compare January 29, 2026 08:50
@scissorsneedfoodtoo scissorsneedfoodtoo marked this pull request as ready for review January 29, 2026 08:56
@scissorsneedfoodtoo scissorsneedfoodtoo requested a review from a team as a code owner January 29, 2026 08:56
@raisedadead raisedadead merged commit a4f565c into main Jan 29, 2026
18 checks passed
@raisedadead raisedadead deleted the fix/search-page-and-localized-search-results branch January 29, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants