github: Wordsmith contributing checklist output #1964
Conversation
concussious
added
needs-review
| msg += "\n> [!NOTE]\n> Please review [CONTRIBUTING](https://github.com/freebsd/freebsd-src/blob/main/CONTRIBUTING.md) guidelines, then update and push your branch again.\n\n" | ||
| } else { | ||
| let msg = "No Issues found.\n\n"; | ||
| let msg = "[CONTRIBUTING](https://github.com/freebsd/freebsd-src/blob/main/CONTRIBUTING.md) guideline checklist found no issues.\n\n"; |
There was a problem hiding this comment.
I think no issues found was better...
There was a problem hiding this comment.
IMO there is some value in including the link also in the "good" case - both because a user might recall this is where the link shows up, and also because it is more precise. Without context "No issues found." might be taken as an indication that the commit has passed code review, testing, etc.
There was a problem hiding this comment.
I'm willing to try it. Just seemed too verbose for n9thing to do.
There was a problem hiding this comment.
Without context "No issues found." might be taken as an indication that the commit has passed code review, testing, etc.
That's what I was thinking. Someone might get really excited and then have their hopes dashed. I'm not attached to any specific wording though.
concussious
force-pushed
the
github-style
branch
from
81c7248 to
ce08d06
Compare
| repo: context.repo.repo, | ||
| comment_id: comment_id, | ||
| body: msg_prefix + "All issues resolved." | ||
| body: msg_prefix + "[CONTRIBUTING](https://github.com/freebsd/freebsd-src/blob/main/CONTRIBUTING.md) checklist issues resolved.\n\n"; |
| msg += "\n> [!NOTE]\n> Please review [CONTRIBUTING](https://github.com/freebsd/freebsd-src/blob/main/CONTRIBUTING.md) guidelines, then update and push your branch again.\n\n" | ||
| } else { | ||
| let msg = "No Issues found.\n\n"; | ||
| let msg = "[CONTRIBUTING](https://github.com/freebsd/freebsd-src/blob/main/CONTRIBUTING.md) guideline checklist found no issues.\n\n"; |
There was a problem hiding this comment.
I'm willing to try it. Just seemed too verbose for n9thing to do.
3 participants
No description provided.