Add QCOM XHCI HIDS and child node parsing - in OBSD source tree for Snapdragon 8cx #1971
+51
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Bauer <[email protected]>
Signed-off-by: Gabriel Bauer <[email protected]>
gjbauer
changed the title
zxombie
reviewed
Jan 27, 2026
Comment on lines
+116
to
+135
| /* | ||
| * The Qualcomm dual role controller has the interrupt on a | ||
| * child node. Find it and parse its resources to find the | ||
| * interrupt. | ||
| */ | ||
| dev_id = acpi_get_pnp_id(dev); | ||
| if (dev_id != NULL && | ||
| (strcmp(dev_id, "QCOM068B") == 0 || strcmp(dev_id, "QCOM068C") == 0)) { | ||
|
|
||
| h = acpi_get_handle(dev); | ||
| if (ACPI_SUCCESS(AcpiGetHandle(h, "USB", &usb_h))) { | ||
| /* xhci_acpi_find_irq will fill child_irq */ | ||
| AcpiWalkResources(usb_h, "_CRS", xhci_acpi_find_irq, &child_irq); | ||
|
|
||
| if (child_irq > 0) { | ||
| /* Override the resource for this device */ | ||
| bus_set_resource(dev, SYS_RES_IRQ, 0, child_irq, 1); | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Why is this in generic_xhci.c? It's ACPI specific so should be in generic_xhci_acpi.c
Author
There was a problem hiding this comment.
So, I presume I should place this in generic_xhci_acpi_probe instead?
Member
There was a problem hiding this comment.
It should be placed in a new acpi attach function. This will then call the current generic attach function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD added these HIDs in a commit to expand support for the Snapdragon 8cx Gen 3 ARM64 SoC. I added them to the source tree and implemented the child node parsing logic in the XHCI code. Check out the full commit here. I am new to FreeBSD contribution. I would like to learn more!!