vm_fault: expand KASSERT message in vm_fault_populate_cleanup#2038
vm_fault: expand KASSERT message in vm_fault_populate_cleanup#2038isoux wants to merge 1 commit intofreebsd:mainfrom
Conversation
sys/vm/vm_fault.c
Outdated
| __func__, | ||
| (uintmax_t)pages.index, | ||
| (uintmax_t)last, | ||
| (uintmax_t)first, | ||
| object)); |
There was a problem hiding this comment.
style(9): Please avoid putting each argument on its own line. Instead, try to wrap the entire statement to a line width of 80 characters.
| __func__, | |
| (uintmax_t)pages.index, | |
| (uintmax_t)last, | |
| (uintmax_t)first, | |
| object)); | |
| __func__, (uintmax_t)pages.index, (uintmax_t)last, | |
| (uintmax_t)first, object)); |
There was a problem hiding this comment.
Thanks, adjusted formatting to follow style(9).
There was a problem hiding this comment.
Thanks, updated the message formatting as suggested by kostikbel.
isoux
force-pushed
the
improve-kassert-vm
branch
from
c78c1ea to
e919172
Compare
kostikbel
left a comment
kostikbel
left a comment
There was a problem hiding this comment.
I am fine with this.
My suggestion would be to put the message like "Object %p first %#jx last %#jx index %#jx" instead. We do not use '=', and put the object pointer first. But all of this is cosmetics.
Include index values and object pointer in the diagnostic to improve debugging of pindex mismatches. No functional change. Signed-off-by: Isa Isoux <isa@isoux.org>
isoux
force-pushed
the
improve-kassert-vm
branch
from
e919172 to
86aa78c
Compare
spmzt
added
staged
|
Automated message from ghpr: Thank you for your submission. This PR has been merged to FreeBSD's |
Include index values and object pointer in the diagnostic to improve debugging of pindex mismatches. No functional change. Signed-off-by: Isa Isoux <isa@isoux.org> Reviewed by: kib, pouria Pull Request: #2038
3 participants
Include index values and object pointer in the diagnostic to improve debugging of pindex mismatches.
No functional change.