Skip to content

arch: Move i386 to EXTRA_ARCHES#2052

Open
mchoo7 wants to merge 1 commit intofreebsd:mainfrom
mchoo7:x86
Open

arch: Move i386 to EXTRA_ARCHES#2052
mchoo7 wants to merge 1 commit intofreebsd:mainfrom
mchoo7:x86

Conversation

@mchoo7
Copy link
Contributor

@mchoo7 mchoo7 commented Feb 27, 2026

Since i386 isn't supported starting from FreeBSD 15, move it to extra archs to prevent build(7) from make targets, make universe, or make tinderbox.

Reported by: siva
Sponsored by: The FreeBSD Foundation

@mchoo7 mchoo7 requested review from bapt and bsdimp as code owners February 27, 2026 13:02
@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Thank you for taking the time to contribute to FreeBSD!

There is an issue that needs to be resolved:

  • Missing Signed-off-by lines (690602f)

Note

Please review CONTRIBUTING.md, then update and push your branch again.

Some of files have special handling:

Important

@bsdimp @bapt @bdrewery @brooksdavis @emaste wants to review changes to share/mk

@mchoo7
Copy link
Contributor Author

mchoo7 commented Feb 27, 2026

ping @svmhdvn

@mchoo7
Copy link
Contributor Author

mchoo7 commented Feb 27, 2026

This is less controversial version of #1956

@svmhdvn
Copy link
Contributor

svmhdvn commented Feb 27, 2026

make targets seems to now exclude i386, but adding -DEXTRA_ARCHES does not re-include it:

With this patch:

$ make targets
Supported TARGET/TARGET_ARCH pairs for world and kernel targets
    amd64/amd64
    arm/armv7
    arm64/aarch64
    powerpc/powerpc64
    powerpc/powerpc64le
    riscv/riscv64

$ make -DEXTRA_TARGETS targets
Supported TARGET/TARGET_ARCH pairs for world and kernel targets
    amd64/amd64
    arm/armv7
    arm64/aarch64
    powerpc/powerpc64
    powerpc/powerpc64le
    powerpc/powerpc
    riscv/riscv64

Note that powerpc/powerpc is there, but i386/i386 is not.

Since i386 isn't supported starting from FreeBSD 15, move it to extra
archs to prevent build(7) from `make targets`, `make universe`, or
`make tinderbox`.

Reported by:	siva
Sponsored by:	The FreeBSD Foundation
@mchoo7
Copy link
Contributor Author

mchoo7 commented Feb 27, 2026

I updated the diff. This works:

$ make targets
Supported TARGET/TARGET_ARCH pairs for world and kernel targets
    amd64/amd64
    arm/armv7
    arm64/aarch64
    powerpc/powerpc64
    powerpc/powerpc64le
    riscv/riscv64

$ make -DEXTRA_TARGETS targets
Supported TARGET/TARGET_ARCH pairs for world and kernel targets
    amd64/amd64
    arm/armv7
    arm64/aarch64
    i386/i386
    powerpc/powerpc64
    powerpc/powerpc64le
    powerpc/powerpc
    riscv/riscv64

@emaste emaste requested a review from bsdjhb February 27, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants