rc.subr: Fix svcj_all_enable

[kimminss0]

Ensure ${name}_svcj falls back to svcj_all_enable if it is not explicitly set.

[github-actions]

Thank you for taking the time to contribute to FreeBSD!

All issues resolved.

[bsdimp]

So when would the old code not fall back? What's being fixed here?

[kimminss0]

svcj_all_enable was broken and did not properly set ${name}_svcj to YES or NO, leaving it as an empty string, which led to the following errors on my fresh FreeBSD 15.0 installation when svcj_all_enable was set:

# dmesg -a | grep svcj
/etc/rc: WARNING: $ip6addrctl_svcj is not set properly - see rc.conf(5).
/etc/pccard_ether: WARNING: $pccard_ether_svcj is not set properly - see rc.conf(5).
/etc/pccard_ether: WARNING: $pccard_ether_svcj is not set properly - see rc.conf(5).
/etc/rc: WARNING: $static_arp_svcj is not set properly - see rc.conf(5).
/etc/rc: WARNING: $syslogd_svcj is not set properly - see rc.conf(5).
/etc/rc: WARNING: $syslogd_svcj is not set properly - see rc.conf(5).
/etc/rc: WARNING: $syslogd_svcj is not set properly - see rc.conf(5).
/etc/rc: WARNING: $background_fsck_svcj is not set properly - see rc.conf(5).

I also checked jls and confirmed that no service jail was created.

[kimminss0]

Updated log with rc_debug="YES" (in addition to svcj_all_enable="YES"):

# dmesg -a | grep svcj
/etc/rc: DEBUG: checkyesno: dumpon_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: sysctl_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: hostid_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: ccd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: swap_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: fsck_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: root_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: hostid_save_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: mountcritlocal_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: var_run_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: kldxref_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: kld_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: devmatch_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: localpkg_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: cleanvar_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: mixer_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: ldconfig_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: hostname_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: adjkerntz_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: netoptions_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: random_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: geli2_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: iovctl_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: ip6addrctl_svcj is set to .
/etc/rc: WARNING: $ip6addrctl_svcj is not set properly - see rc.conf(5).
/etc/rc: DEBUG: checkyesno: rctl_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: netif_svcj is set to NO.
/etc/rc.d/ipfilter: DEBUG: checkyesno: ipfilter_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: devd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: devd_svcj is set to NO.
/etc/rc.d/devmatch: DEBUG: checkyesno: devmatch_svcj is set to NO.
/etc/rc.d/devmatch: DEBUG: checkyesno: devmatch_svcj is set to NO.
/etc/pccard_ether: DEBUG: checkyesno: pccard_ether_svcj is set to .
/etc/pccard_ether: WARNING: $pccard_ether_svcj is not set properly - see rc.conf(5).
/etc/pccard_ether: DEBUG: checkyesno: pccard_ether_svcj is set to .
/etc/pccard_ether: WARNING: $pccard_ether_svcj is not set properly - see rc.conf(5).
/etc/rc.d/dhclient: DEBUG: checkyesno: dhclient_svcj is set to NO.
/etc/rc.d/dhclient: DEBUG: checkyesno: dhclient_svcj is set to NO.
/etc/rc.d/devmatch: DEBUG: checkyesno: devmatch_svcj is set to NO.
/etc/rc.d/devmatch: DEBUG: checkyesno: devmatch_svcj is set to NO.
/etc/rc.d/devmatch: DEBUG: checkyesno: devmatch_svcj is set to NO.
/etc/rc.d/devmatch: DEBUG: checkyesno: devmatch_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: stf_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: resolv_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: static_ndp_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: static_arp_svcj is set to .
/etc/rc: WARNING: $static_arp_svcj is not set properly - see rc.conf(5).
/etc/rc: DEBUG: checkyesno: bridge_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: routing_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: defaultroute_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: mountcritremote_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: newsyslog_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: devfs_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: cleartmp_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: dmesg_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: virecover_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: motd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: osrelease_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: gptboot_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: syslogd_svcj is set to .
/etc/rc: WARNING: $syslogd_svcj is not set properly - see rc.conf(5).
/etc/rc: DEBUG: checkyesno: syslogd_svcj is set to .
/etc/rc: WARNING: $syslogd_svcj is not set properly - see rc.conf(5).
/etc/rc: DEBUG: checkyesno: syslogd_svcj is set to .
/etc/rc: WARNING: $syslogd_svcj is not set properly - see rc.conf(5).
/etc/rc: DEBUG: checkyesno: pwcheck_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: nisdomain_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: utx_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: local_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: mountlate_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: ntpd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: ntpd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: swaplate_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: cron_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: cron_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: syscons_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: sysctl_lastload_svcj is set to NO.
/etc/rc.d/sysctl: DEBUG: checkyesno: sysctl_svcj is set to NO.
/etc/rc.d/sysctl: DEBUG: checkyesno: sysctl_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: msgs_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: sshd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: sshd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: sshd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: sshd_svcj is set to NO.
/etc/rc: DEBUG: checkyesno: background_fsck_svcj is set to .
/etc/rc: WARNING: $background_fsck_svcj is not set properly - see rc.conf(5).