Conversation
|
Thank you for taking the time to contribute to FreeBSD! There is an issue that needs to be resolved:
Note Please review CONTRIBUTING.md, then update and push your branch again. Some of files have special handling: Important @concussious wants to review changes to share/man/ |
|
Yea this is ready unless you have any comments. |
mhorne
left a comment
There was a problem hiding this comment.
This is sensible, and probably what was intended, based on the API of pmc_capbilities().
The new PMC_OP_GETCAPS op needs to be added to the hwpmc(4) man page.
|
I'll update the docs for hwpmc in this patch. I'm still holding a few code patches that need to land to unblock a few other external collaborators. Once I get those out this week, I'll make my final pass on my hwpmc amd/ibs docs and push those too. |
Sounds great, many thanks. |
1d2ea7c to
c8acd87
Compare
c8acd87 to
960ac84
Compare
mhorne
left a comment
There was a problem hiding this comment.
Thanks. I will merge today.
This change allows for fine-grained capabilities per counter index. This is particularly useful for AMD where subclasses are not exposed to the general PMC code, but other architectures also have asymmetric behaviors when it comes to specific counter indices. A new PMC_OP_GETCAPS op is added to the hwpmc(4) ioctl interface. Reviewed by: mhorne Sponsored by: Netflix Pull Request: #2058
|
Merged with some small minor tweaks to style (argument order) and to the commit message. |
|
As a follow-up I bumped |
This change allows for fine-grained capabilities per counter index. This is particularly useful for AMD where subclasses are not exposed to the general PMC code, but other architectures also have assymetric behaviors when it comes to specific counter indicies. Sponsored by: Netflix
This change allows for fine-grained capabilities per counter index. This is particularly useful for AMD where subclasses are not exposed to the general PMC code, but other architectures also have assymetric behaviors when it comes to specific counter indicies.
Sponsored by: Netflix