Skip to content

crypto_request.9: Fix typo#2077

Closed
zxbv3 wants to merge 1 commit intofreebsd:mainfrom
zxbv3:zxbv3-patch-1
Closed

crypto_request.9: Fix typo#2077
zxbv3 wants to merge 1 commit intofreebsd:mainfrom
zxbv3:zxbv3-patch-1

Conversation

@zxbv3
Copy link
Contributor

@zxbv3 zxbv3 commented Mar 15, 2026

The function signature of crypto_initreq() was incorrectly documented.

The function signature of `crypto_initreq()` was incorrectly documented.

Signed-off-by: Zixu Wu <zx@bv3.dev>
@github-actions
Copy link

Thank you for taking the time to contribute to FreeBSD!

Some of files have special handling:

Important

@concussious wants to review changes to share/man/

@spmzt spmzt requested review from concussious and spmzt March 15, 2026 19:22
Copy link
Member

@spmzt spmzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spmzt spmzt added the needs-review Someone should look at this before proceeding label Mar 15, 2026
.\"
.\" * Other names and brands may be claimed as the property of others.
.\"
.Dd May 8, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@concussious
Should the manual date be updated in here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Although close to a typo, since it was a cut and paste error, it does change the content enough. I usually do that when I land the commit before pushing (though maybe ghpr should have that as an option?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is correct, I'll update the manual date if either you or Ziaee approve it.

@spmzt spmzt added the man-only Only contains man page changes label Mar 15, 2026
@spmzt spmzt self-assigned this Mar 15, 2026
Copy link
Contributor

@concussious concussious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both!

@spmzt spmzt added staged Devevloper has this staged and will push or reject pending testing. merged Closed commit that's been merged and removed staged Devevloper has this staged and will push or reject pending testing. labels Mar 16, 2026
@spmzt
Copy link
Member

spmzt commented Mar 16, 2026

Automated message from ghpr: Thank you for your submission. This PR has been merged to FreeBSD's main branch. These changes will appear shortly on our GitHub mirror.

@spmzt spmzt closed this Mar 16, 2026
@spmzt spmzt removed the needs-review Someone should look at this before proceeding label Mar 16, 2026
freebsd-git pushed a commit that referenced this pull request Mar 16, 2026
The function signature of `crypto_initreq()` was
incorrectly documented.

Signed-off-by:	Zixu Wu <zx@bv3.dev>
Reviewed by:	ziaee, pouria
Pull Request:	#2077
@spmzt spmzt removed the man-only Only contains man page changes label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged Closed commit that's been merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants