Skip to content

linuxulator: improve getxattr() error handling #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilovegrape wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

linuxulator: improve getxattr() error handling #2263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion sys/compat/linux/linux_xattr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,18 +310,34 @@ static int
getxattr(struct thread *td, struct getxattr_args *args)
{
char attrname[LINUX_XATTR_NAME_MAX + 1];
ssize_t size;
int attrnamespace, error;

error = xattr_to_extattr(args->name, &attrnamespace, attrname);
if (error != 0)
return (error);
if (args->path != NULL)
error = kern_extattr_get_path(td, args->path, attrnamespace,
attrname, NULL, 0, args->follow, UIO_USERSPACE);
else
error = kern_extattr_get_fd(td, args->fd, attrnamespace,
attrname, NULL, 0);
if (error != 0)
goto out;
if (args->value == NULL || args->size == 0)
return (0);
size = td->td_retval[0];
if (size > args->size)
return (ERANGE);
if (args->path != NULL)
error = kern_extattr_get_path(td, args->path, attrnamespace,
attrname, args->value, args->size, args->follow, UIO_USERSPACE);
else
error = kern_extattr_get_fd(td, args->fd, attrnamespace,
attrname, args->value, args->size);
return (error == EPERM ? ENOATTR : error);

out:
return (error == EPERM || error == EOPNOTSUPP ? ENOATTR : error);
}

int
Expand Down
Loading