fix(examples): resolve high/medium audit findings#73
Merged
Conversation
Fix correctness/drift in the full-stack examples (not covered by CI): - talos-full-stack: add sbc_overlay = "turingrk1" (required for RK1 boot), pass talos_version to the cluster module (config/image version match). - both examples: drop the insecure 5-char grafana_password default "admin" that failed the monitoring module's >=8-char validation; add module.ingress to the monitoring depends_on (Grafana ingress webhook race); restandardize example IPs to 10.10.88.x. - talos tfvars.example: stop defaulting talos_firmware to a stale local v1.9.1 path (commented out so the generated overlay image is used). Verified: terraform fmt -check, and terraform validate on both examples.
Merged
jfreed-dev
added a commit
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the high and medium findings from the examples audit (the
examples/configs are not covered by CIValidatejobs, so they had drifted).High
talos-full-stack: missingsbc_overlay = "turingrk1"(RK1 won't boot) — added.grafana_passworddefaulted to"admin"(5 chars), failing the monitoring module's>= 8validation on the default path — default removed (now required).Medium
talos-full-stack: cluster module now receivestalos_version(config/image version match).depends_onnow includesmodule.ingress(Grafana ingress admission-webhook race).talos-full-stacktfvars:talos_firmwareno longer points at a stale local v1.9.1 path (commented out → uses the generated overlay image).10.10.88.x(v1.6.0 convention).Low items (120s boot wait,
required_version >= 1.0floor) intentionally left out of scope.Verified:
terraform fmt -checkclean andterraform validatepasses on both examples. Lands under CHANGELOG [Unreleased].🤖 Generated with Claude Code