Skip to content

fix(#531): keep disconnect_vpn_by_uuid returning Ok(()) for unknown UUIDs - #533

Merged
cachebag merged 3 commits into
masterfrom
fix/integration-tests
Sep 1, 2026
Merged

cachebag merged 3 commits into
masterfrom
fix/integration-tests

Conversation

@cachebag

@cachebag cachebag commented Sep 1, 2026

Copy link
Copy Markdown
Member

Map the variant back to Ok(()) in the wrapper so the deprecated method keeps its original behavior.

Also records the missing [Unreleased] changelog entries for #531.

… UUIDs

The deprecated wrapper now delegates to `disconnect_by_uuid`, which
reports an unmatched UUID as `SavedConnectionNotFound`. Previously it
fell through its active-connection loop and returned `Ok(())` for any
UUID it did not match, so an idempotent disconnect that succeeded in
3.5.0 started erroring within the same major.
@cachebag cachebag self-assigned this Sep 1, 2026
@cachebag cachebag added documentation Improvements or additions to documentation tests Add, remove or adjust tests nm-compat NetworkManager compatibility or runtime rejection labels Sep 1, 2026
@cachebag
cachebag deployed to self-hosted-pr-integration September 1, 2026 15:33 — with GitHub Actions Active
@cachebag
cachebag deployed to self-hosted-pr-integration September 1, 2026 15:37 — with GitHub Actions Active
@cachebag
cachebag enabled auto-merge September 1, 2026 15:37
@cachebag
cachebag disabled auto-merge September 1, 2026 15:37
@cachebag
cachebag merged commit a12b9d7 into master Sep 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation nm-compat NetworkManager compatibility or runtime rejection tests Add, remove or adjust tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant