Skip to content

Split out Inbox Release Management and update - #309

Open
legoktm wants to merge 1 commit into
mainfrom
inbox-release
Open

Split out Inbox Release Management and update#309
legoktm wants to merge 1 commit into
mainfrom
inbox-release

Conversation

@legoktm

@legoktm legoktm commented Aug 10, 2026

Copy link
Copy Markdown
Member

Move to its own file now that the process is (temporarily) diverging from the Workstation.

Incorporate the new release schedule, the freeze on main, and lack of release branches. Add notes that apt-test and apt-prod PRs will soon be automated, and flag that the preflight instructions are already out of date.

Checklist

This change accounts for:

  • local preview of changes beyond typo-level edits

Move to its own file now that the process is (temporarily) diverging
from the Workstation.

Incorporate the new release schedule, the freeze on main, and lack of
release branches. Add notes that apt-test and apt-prod PRs will soon be
automated, and flag that the preflight instructions are already out of
date.
@legoktm legoktm moved this to Ready For Review in SecureDrop Aug 10, 2026
@nathandyer
nathandyer self-requested a review August 11, 2026 16:06
@nathandyer nathandyer self-assigned this Aug 11, 2026
@nathandyer nathandyer moved this from Ready For Review to Under Review in SecureDrop Aug 12, 2026

@nathandyer nathandyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly looking good.

There's an issue with the indentation of all the code blocks that will need to be corrected, but that's the only substantive issue I'm seeing.

Also just a note: in the main securedrop docs repo we've moved away from hard line breaks, but I'm not applying that requirement here because we haven't actually established that as a requirement in this repo, and also because we'll need to eliminate them in all the existing docs before we can apply this uniformly to new PRs.


git clone git@github.com:freedomofpress/securedrop-client.git
git clone git@github.com:freedomofpress/securedrop-builder.git

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an indent-level issue with all the code blocks here.

As it stands, it's currently putting all the code blocks inside a quote block. It's also considering them nested under the parent rather than the individual bullet items.

See the before:

Image

Vs after:

Image
Suggested change
.. code-block:: sh
git clone git@github.com:freedomofpress/securedrop-client.git
git clone git@github.com:freedomofpress/securedrop-builder.git

I defer to @legoktm for where it makes sense to nest it inline with the step vs with the parent, the above suggestion is just one example of how this could be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Under Review

Development

Successfully merging this pull request may close these issues.

2 participants