Remove "environment" from config.json#1393
Closed
rocodes wants to merge 11 commits intofeat/sdw-keyring-compatfrom
Closed
Remove "environment" from config.json#1393rocodes wants to merge 11 commits intofeat/sdw-keyring-compatfrom
rocodes wants to merge 11 commits intofeat/sdw-keyring-compatfrom
Conversation
rocodes
force-pushed
the
remove-environment-from-json-config
branch
2 times, most recently
from
12781d9 to
a8b3f41
Compare
This was referenced Aug 18, 2025
rocodes
force-pushed
the
remove-environment-from-json-config
branch
4 times, most recently
from
780eee6 to
1cb7e01
Compare
…ing key and repo urls.
…y shipped to dom0 in /etc/pki from securedrop-workstation-keyring. Key must be cached by dom0 and retrieved by the vm. Consolidate all apt repo configuration into sd-default-config.sls (delete sd-default-config.yml). Rename sdvars to apt_config for clarity.
…he keyring is used consistently across yum and apt components. Move test_sources functionality out of launcher tests. Deprecate skip_in_dom0 conftest annotation.
…bootstrap is complete
…dd it to bootstrap target openqa
rocodes
force-pushed
the
remove-environment-from-json-config
branch
from
1cb7e01 to
de36543
Compare
…of environment-specific .repo file instead. Remove environment flag.
…fce configuration.
rocodes
force-pushed
the
remove-environment-from-json-config
branch
from
de36543 to
4bd118c
Compare
…nment via .repo file and installed packages in dom0 tests. Check environment via .repo files instead of config.json in VM tests. openqa
rocodes
force-pushed
the
remove-environment-from-json-config
branch
from
4bd118c to
0067dee
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR, depends on #1392
Remove "environment" from config.json . (more tk)
Test plan
feat/sdw-keyring-compatnot main!openqa, full CI run passingChecklist
This change accounts for:
MANIFEST.inandrpm-build/SPECS/securedrop-workstation-dom0-config.spec)