#6405 Fix wcag annotations#7314
Conversation
zenmonkeykstop
left a comment
zenmonkeykstop
left a comment
There was a problem hiding this comment.
Thanks for this @amnak613 - I had a few questions, see the review!
| <dialog open id="delete-confirm-menu-dialog" aria-labelledby="confirm-heading"> | ||
| <h2 id="confirm-heading" class="paragraph-spacing"> | ||
| {{ gettext('When the account for a source is deleted:') }} | ||
| {{ gettext('When the account for a <abr title="user">source</abr>is deleted:') }} |
There was a problem hiding this comment.
AFAICT the tag should be <abbr title="..."> not <abr title="..."> - unsure if both are valid.
There was a problem hiding this comment.
Looked it up and both are valid - https://www.w3schools.com/tags/tag_abbr.asp
| </h2> | ||
| <ul> | ||
| <li>{{ gettext('The source will no longer be able to log in with their codename.') }}</li> | ||
| <li>{{ gettext('The <abr title="user">source</abr> will no longer be able to log in with their <abbr title="user name">codename</abbr>.') }}</li> |
There was a problem hiding this comment.
It's unclear that terms like source and codename are ones that should have an abbr tag (vs the OATH-HOTP instance below, which definitely should!) - is there a reason they're included?
There was a problem hiding this comment.
The reason why I thought it would be nice to have was because its a bit unclear as a new user what a codename is as its a term used specifically by the app. Let me know if I need to update @zenmonkeykstop
| <a href="{{ url_for('admin.manage_config') }}" class="btn icon icon-edit section-spacing-inline" | ||
| id="update-instance-config" aria-label="{{ gettext('Update instance configuration') }}"> | ||
| {{ gettext('INSTANCE CONFIG') }} | ||
| {{ gettext('INSTANCE CONFIGURATION') }} |
There was a problem hiding this comment.
This is probably out of scope for WCAG annotations and will require translation changes.
There was a problem hiding this comment.
okay, sounds good - will remove for now
|
Hi @amnak613, just checking in - to be mergeable this would need a rebase and any final pending tweaks. Do you still want to poke at this, or would you like us to pick this up ourselves when we have a chance? |
|
(We'll pick this up ourselves when we have a chance, moving to backlog for now.) |
3 participants
Status
Ready for review / Work in progress
Description of Changes
Added abbreviation descriptions to the html pages.
Fixes #6405. and the closed pr: #7081
Changes proposed in this pull request:
Testing
How should the reviewer test this PR?
Write out any special testing steps here.
-when looking through the page ensure the correct words have abbreviations
Deployment
Any special considerations for deployment? Consider both:
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you added or removed a file deployed with the application:
If you made non-trivial code changes:
Choose one of the following:
If you added or updated a reference to a production code dependency:
Production code dependencies are defined in:
admin/requirements.inadmin/requirements-ansible.insecuredrop/requirements/python3/requirements.insecuredrop/requirements/python3/translation.in(used in the buildcontainer)
If you changed another
requirements.infile that applies only to developmentor testing environments, then no diff review is required, and you can skip
(remove) this section.
Choose one of the following: