Fix division by zero in delete-disconnected-fs-submissions#7746
Open
heathdutton wants to merge 2 commits into
Open
Fix division by zero in delete-disconnected-fs-submissions#7746heathdutton wants to merge 2 commits into
heathdutton wants to merge 2 commits into
Conversation
Member
|
@heathdutton hi, thanks for submitting all these PRs! It'll take us a bit of time to get to reviewing them as our main priority is on the SecureDrop Workstation side of things right now. And you don't need to keep updating them, if there are conflicts we'll rebase when needed. Also please let us know if you used any AI/LLM tools when creating these so we can review accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7201
When deleting disconnected filesystem submissions, if a file has zero bytes,
ratebecomes 0 after the first deletion. On subsequent iterations, the ETA calculationfilesize / ratecauses aZeroDivisionError.This adds a guard to skip the ETA calculation when rate is zero.
Test plan
manage.py delete-disconnected-fs-submissions --forceChecklist
This change accounts for: