Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Nov 21, 2025

Remove check 0841-content-02 (aria-current attribute requirement)

Summary

Removed accessibility check condition 0841-content-02 from design check ID 0841. This condition previously required that the aria-current attribute be properly specified on navigation elements indicating the current page position.

Key changes:

  • Removed condition 0841-content-02 which checked for proper aria-current attribute usage in global navigation/breadcrumbs
  • Simplified YAML structure: converted from and condition (requiring both visual indication AND aria-current) to a single simple condition (requiring only visual indication)
  • Check 0841 now passes if either:
    • No global navigation/breadcrumbs exist (0841-content-00), OR
    • Position is visually indicated (0841-content-01)

Review & Testing Checklist for Human

  • Verify this aligns with accessibility requirements: Confirm that removing the aria-current attribute requirement is acceptable for your accessibility standards (this was a WCAG-related technical requirement)
  • Confirm logic change is intentional: The check logic changed from AND (visual indication + aria-current) to OR (visual indication only). Verify this matches the intended behavior.
  • Consider documentation needs: Determine if this change should be documented in a changelog or communicated to teams currently using these guidelines

Test Plan

  1. Build the documentation locally with make html
  2. Verify that check 0841 in ja/build/html/checks/checklist.html no longer references 0841-content-02
  3. Confirm the check procedure now shows "0841-content-00 または 0841-content-01" (OR logic)

Notes

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@ymrl
Copy link
Member

ymrl commented Nov 21, 2025

devinによるPull RequestのテストとしてPRしました。

社内での議論として、以下のような理由でこのチェック項目は削除して良いのではないかということになりました。

  • グローバルナビゲーション等、ナビゲーション用のコンポーネントは定義されたものが使用されることがほとんど
  • それらのコンポーネントでは、視覚的に現在位置を表現する機能が備わっていて、aria-current もそれと連動している
  • コードを書かないデザイナーが aria-current 等のWAI-ARIA属性を考慮するのは難しい

@devin-ai-integration
Copy link
Contributor Author

ありがとうございます!チェック項目0841-content-02の削除が完了しました。

ご説明いただいた理由(コンポーネントの標準化、視覚表現とaria-currentの連動、デザイナーの負担軽減)を踏まえると、この変更は妥当だと思います。

変更内容:

  • 0841-content-02(aria-current属性の要件)を削除
  • チェックロジックを「視覚的表現 AND aria-current」から「視覚的表現のみ」に簡略化

すべてのテストとCIチェックが正常に完了しています。マージの準備ができています。

@ymrl ymrl requested review from shikakun and ymrl November 28, 2025 03:11
@ymrl ymrl merged commit 50c2a54 into develop Nov 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants