Open
Conversation
Author
|
Also tagging @jcushman for visibility. |
Member
Author
|
Hi @mlissner! sorry for the late response, and my bad -- it seems like I may have included some of the regex patterns in the examples page, which polluted the tests. These should be updated now! |
Member
|
This should be back to you, then, @flooie. |
Collaborator
|
@4ndygu this looks great. Thank you for adding your two cents. I hope to give this a deeper look tomorrow. |
Collaborator
Author
|
Hi @flooie! Just to clarify, might be my bad here -- i think the error arose because I accidentally added two patterns to the |
Collaborator
|
That sounds like it would cause the fail for sure.
… On Jul 12, 2021, at 5:39 PM, Andy Gu ***@***.***> wrote:
Hi @flooie! Just to clarify, might be my bad here -- i think the error arose because I accidentally added two patterns to the examples section as opposed to regex, which would have caused the existing regex patterns at the time to fail.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! I am currently mining some of the data in the Caselaw Access Project API, and we noticed that some of the Regex patterns in
courts.jsondo not match the courts displayed in api.case.law/v1/courts/. This pull requests takes a subset of the most frequently seen courts in CAP and adds those court names to the Regex pattern of the underlying dataset.