Added fixes and tweaks #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freemansoft
requested changes
Mar 17, 2022
Owner
freemansoft
left a comment
freemansoft
left a comment
There was a problem hiding this comment.
Noted a couple of typos and asked for a couple of lines that describe how to execute it using the external config file.
|
|
||
| function defaultPrompt { | ||
| if ($null -eq $ConfigFile) { | ||
| $DefaultPrompt = Read-Host = "Would you like to load the default values to the config file? (Y/N)" |
Owner
There was a problem hiding this comment.
Is this going to save defaults to a config file or load them from a config file. I'm not sure from the prompt.
| $Script:StorageSpacesParams | ConvertTo-Json | Out-File $PSScriptRoot + "\TieredStorageSpace-Config.json" | ||
| } | ||
| elseif ($DefaultPrompt.ToUpper() -eq "N") { | ||
| Read-Host "Ether pass the config file to the script or use default values. Exiting..." |
| @@ -1,8 +1,11 @@ | |||
| # Create Storage Spaces in Windows 10 | |||
|
|
|||
| <!--TODO: Update README documrntaion to match new scripts usage. /---> | |||
Owner
There was a problem hiding this comment.
documrntation should be "documentation".
| # Scripts | ||
| ## new-storage-space.ps1 | ||
| ## New-TieredStorageSpace.ps1 | ||
| Creates a tiered storage pool and allocates all the disk space to a single drive |
Owner
There was a problem hiding this comment.
Can we add a line here or at the top that tells us how to run the script with the external configuration file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.