fix: improve spaces when label is not defined (#450) #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabarchonok
requested review from
jonotrujillo and
dornelasnelson
as code owners
The margin has been removed in favour of gap to get rid of unnecessary indentation when label undefined
kabarchonok
force-pushed
the
450/fix-checkbox-spaces
branch
from
14850e9 to
d4577ab
Compare
There was a problem hiding this comment.
Hey @kabarchonok, thanks a lot for contributing to wave. I've left a few comments and suggestions. I'm talking with the team to understand whether this is really relevant as the issue was about wave version 1 and we are at version 2 now but I ran your forked repo here and it looks like it works well.
|
@dornelasnelson You're welcome! I just did it for fun, so I don't pretend to be opinionated. |
dornelasnelson
approved these changes
Feb 6, 2025
AlanFnz
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replaced
marginwithgapin Checkbox, RadioButton and Toggle components to improve UI when no label is undefined.Also slightly changed the default history for the Checkbox similar to other components, made the default label undefined.
Why
Closes #450