Skip to content

Conversation

@mshriner
Copy link
Contributor

Addresses #2

  • improve typescript typing
  • resolve sonar(javascript:S2310)
  • add xo badge to README
  • upgrade testing dependencies

Copy link
Owner

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@mshriner mshriner requested a review from fregante June 1, 2025 19:47
@mshriner
Copy link
Contributor Author

mshriner commented Jun 1, 2025

@fregante Would you please run the workflows again for me? If they fail again I can try further downgrading those dev dependencies.

@mshriner
Copy link
Contributor Author

mshriner commented Jun 4, 2025

Running xo locally produces a lot more errors than the GitHub Actions that just ran... I only fixed the ones the Actions version complained about.

@mshriner mshriner requested a review from fregante June 8, 2025 05:12
@fregante fregante merged commit 84cbdcc into fregante:main Jun 8, 2025
11 checks passed
@fregante
Copy link
Owner

fregante commented Jun 8, 2025

Running xo locally produces a lot more errors than the GitHub Actions that just ran

Not for me, it's more likely that your npm install failed or you're not using the right node version. But it's ok, thank you for the PR and sorry for the long review time!

@mshriner mshriner deleted the mshriner-typescript-typing branch June 29, 2025 01:28
@mshriner mshriner mentioned this pull request Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants