action: allow setting another container image URL#1
Open
herbetom wants to merge 6 commits intofreifunk-gluon:masterfrom
Open
action: allow setting another container image URL#1herbetom wants to merge 6 commits intofreifunk-gluon:masterfrom
herbetom wants to merge 6 commits intofreifunk-gluon:masterfrom
Conversation
Gluon switched from master to main
This allows you to use a custom Container of your choosing. Unfortunately the only way to make the default URL work, even if there is supplied an empty string, seems to be to duplicate the docker build command. This is important because it makes integrating this action much easier.
Without this the deprecated input of the action has no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows you to use a custom Container of your choosing.
Unfortunately the only way to make the default URL work, even if there is supplied an empty string, seems to be to duplicate the docker build command.
This is important because it makes integrating this action much easier.
In addition this does some maintenance work like updating the CI of this action etc.
It would be be great to get a
v2tag once this is (hopefully) merged. The changes should hoewer also be backwards compatible with overriding thev1tag.Related: freifunk-gluon/action-sign#1