Adding ffhl-gluon-mesh-batman-adv-brmldproxy

[T-X]

This is a copy of #2995 for the main Gluon repository:
-> freifunk-gluon/gluon#2995

[grische]

As both PRs are still open, do you want to host the package here only temporarily? Or is this different to the Gluon PR?

[rotanid]

we will adjust the shellcheck config in order to be similar to the main repository

[rotanid]

@T-X i added a .shellcheckrc and fixed small issues, but one thing remains, please have a look

[rotanid]

@T-X do you want to merge it here or copy the code to these PRs:
freifunk-gluon/gluon#2995
freifunk-gluon/packages#264

on 2025-04-15 we decided on mumble meeting, that @neocturne will review this here but the merge will happen in the main repositories.

[neocturne]

on 2025-04-15 we decided on mumble meeting, that @neocturne will review this here but the merge will happen in the main repositories.

Well, reviewing it here will have to do if the PR in the main repo is not up-to-date... but of course I'd prefer to review where we intend to merge it.

[neocturne]

I've never received a reply to my previous comment. We still intend to merge this to the Gluon main repo, right? Wouldn't it make more sense to close this PR then?

[rotanid]

why would we discuss it again after having made a decision at the meeting? i don't get it, but in the end i don't care much i just wanted to push it forward without having personal interest in the change.

[neocturne]

I thought we decided that this PR only made sense because we hadn't fixed our lints in the main repo.

[T-X]

My motivation for this PR was that I wasn't sure how long it would take to be integrated into the main repository. And wanted to add here quickly what we are basically already using in Lübeck. While I would still prefer getting this into the main repository eventually.

We've had some early reviewing in the freifunk-gluon/gluon#2995 PR and then later some linting/style reviewing here. The reviewing split is confusing and unfortunate, sorry about that, but happened because we unintentionally had no linting for the official packages repository and diverging linting checks between this community packages repository and the main repository. This should hopefully be fixed now.

My suggestion would be to hit the merge button here now unless someone sees some further issues in regards to community packages guideline. Then I'd sync the latest style changes / lint fixes to freifunk-gluon/gluon#2995. And we then continue reviewing over there? And once it's merged in the main repository eventually I'd file another PR to remove it again here in community packages.

Does that make sense?

[citronalco]

I just stumbled over this PR, which seems to be stuck, unfortunately.
Maybe the notifications caused by my comment bring back some life.

@T-X In the Makefile's package description, could you please note that filter_membership_reports is true by default?

[T-X]

I just stumbled over this PR, which seems to be stuck, unfortunately. Maybe the notifications caused by my comment bring back some life.

@T-X In the Makefile's package description, could you please note that filter_membership_reports is true by default?

Hi @citronalco, thanks for your interest. I think I did mention that?

If filter_membership_reports is true in the site.conf *or absent* then [...]

Also I think further discussion will continue in the PR for an official Gluon main addition: freifunk-gluon/gluon#2995, not here.

[rotanid]

replaced by
freifunk-gluon/packages#264