[v2021.1.x] Backport build-container action#3700
Closed
herbetom wants to merge 10 commits into
Closed
Conversation
…on#2971) This adds a workflow to push the build-container described in Gluons Dockerfile to the freifunk-gluon organizations container registry. This will create a image - For every push to master - For every tagged version - For every PR against master Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit fa8ee03)
The docker container on PR action is broken in case the PR is not opened within the Gluon project. Remove the build on PR so the pipeline does not fail for third party PRs. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit 9577d2f)
Only push the container to ghcr in case the repository is owned by the freifunk-gluon organization. THis avoids failing CI on forks. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit 26bf66b)
(cherry picked from commit 737671e)
Also build the docker-container whan creating pull-requests. Keep the pull-request triggered builds from pushing to the container registry. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit 7ea311f)
(cherry picked from commit c9d5fd9)
(cherry picked from commit 0358344)
Build and release a docker container for the next branch. Signed-off-by: David Bauer <mail@david-bauer.net> (cherry picked from commit 32256ef)
This is what is left after cherry picking the most important PRs not made by bots.
Member
|
@herbetom can you figure out the CI fail? and amend your commits? |
Member
Author
|
I don't think i'll be able to look into this within a somewhat reasonable timeframe. Closing therefore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports the build-container action to v2021.1.x so that there is an compatible image to build v2021.1.x images with a container from the the registry.
I'm somewhat torn with this PR. I currently "need" such a container so there is that and others could probably also find it helpful down the line as well. But the Release is certainly EoL and there is a good argument to be made that it shouldn't be touched.
Since i'm doing the work anyway i thought hoewer i might as well open the PR and hear what others have to say.
Unfortunately i can't just use one of the existing images because dependencies differ.
Note: The build-container action builds and publishes as expected from my testing. I haven't looked at the other actions of the branch but i also don't think they should be touched this far down the line without a very good reason. This PR therefore doesn't get a green tick from the CI. And neither would the merged commit.