Skip to content

chore: fjern dev-eksempler i jokulpakka til fordel for Storybook #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

piofinn
Copy link
Contributor

@piofinn piofinn commented Apr 8, 2025

💬 Endringer

  1. Fjerner dev-eskemplene i hver pakke i den nye Jøkul monopakka, til fordel for å bruke Storybook til lokal utvikling. Dette fjerner avhengighet til dev-utils på rot, som skaper problemer under bygg av kun den nye pakken.

♿️ Testing

  • pnpm build og pnpm ci:test gir ingen feil

@piofinn piofinn self-assigned this Apr 8, 2025
@piofinn piofinn requested a review from a team as a code owner April 8, 2025 11:08
@fremtind-bot
Copy link
Collaborator

fremtind-bot commented Apr 8, 2025

Forhåndsvisning: https://jokul.fremtind.no/preview/use-storybook-for-dev/
🔍 Commit: 4cd52ba

Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes.

fremtind-bot added a commit that referenced this pull request Apr 8, 2025
@piofinn
Copy link
Contributor Author

piofinn commented Apr 8, 2025

Glemte at disse også brukes for visuelle regresjonstester i Playwright 🤪 Det får bli et større prosjekt å bytte over til å bruke stories i Storybook til dette også.

@piofinn piofinn marked this pull request as draft April 8, 2025 14:58
Copy link
Contributor

@lmfaole lmfaole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

denna blir god as

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants