This repository was archived by the owner on Jun 27, 2018. It is now read-only.
POX path detection using standard tools.#42
Open
jameskyle wants to merge 1 commit intofrenetic-lang:kineticfrom
Open
POX path detection using standard tools.#42jameskyle wants to merge 1 commit intofrenetic-lang:kineticfrom
jameskyle wants to merge 1 commit intofrenetic-lang:kineticfrom
Conversation
Parsing of PYTHONPATH does not account for a standard installation of POX. Catching an ImportError accounts for any valid method of installing POX. Also, instead of searching through all paths and looking for a match on pox, then appending pox.py to that path this patch uses the __file__ attribute of the module itself (after successful import).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing of PYTHONPATH does not account for a standard installation of
POX. Catching an ImportError accounts for any valid method of installing
POX.
Also, instead of searching through all paths and looking for a match on
pox, then appending pox.py to that path this patch uses the file
attribute of the module itself (after successful import).