This repository was archived by the owner on Jun 27, 2018. It is now read-only.
Erase unnecessary import of EthAddr#56
Open
thiagolckurovski wants to merge 1 commit intofrenetic-lang:masterfrom
Open
Erase unnecessary import of EthAddr#56thiagolckurovski wants to merge 1 commit intofrenetic-lang:masterfrom
thiagolckurovski wants to merge 1 commit intofrenetic-lang:masterfrom
Conversation
Importing EthAddr from pox inside simple_ui_firewall.py is unnecessary, as the module isn't using EthAddr and very confusing, as there is one EthAddr defined by Pyretic, and importing and using the one from Pox instead won't work. The best thing to do is just erase the import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing EthAddr from pox inside simple_ui_firewall.py is unnecessary, as the module isn't using EthAddr and very confusing, as there is one EthAddr defined by Pyretic, and importing and using the one from Pox instead won't work. The best thing to do is just erase the import.