Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion deno.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions packages/plugin-vite/demo/islands/tests/Mime.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import * as mime from "mime-db";
import { useEffect, useState } from "preact/hooks";

export function MimeIsland() {
// deno-lint-ignore no-console
console.log(mime);

const [ready, setReady] = useState(false);
useEffect(() => {
setReady(true);
}, []);

return <h1 class={ready ? "ready" : ""}>mime</h1>;
}
5 changes: 5 additions & 0 deletions packages/plugin-vite/demo/routes/tests/mime.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { MimeIsland } from "../../islands/tests/Mime.tsx";

export default function Page() {
return <MimeIsland />;
}
1 change: 1 addition & 0 deletions packages/plugin-vite/deno.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"@prefresh/vite": "npm:@prefresh/vite@^2.4.8",
"@types/babel__core": "npm:@types/babel__core@^7.20.5",
"@types/node": "npm:@types/node@^24.1.0",
"mime-db": "npm:mime-db@^1.54.0",
"preact": "npm:preact@^10.26.9",
"vite": "npm:vite@^7.0.6",
"vite-plugin-inspect": "npm:vite-plugin-inspect@^11.3.2"
Expand Down
7 changes: 5 additions & 2 deletions packages/plugin-vite/src/plugins/deno.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function deno(): Plugin {
return id;
}

const type = getDenoType(options.attributes.type ?? "default");
const type = getDenoType(id, options.attributes.type ?? "default");
if (
type !== RequestedModuleType.Default ||
/^(https?|jsr|npm):/.test(resolved) ||
Expand Down Expand Up @@ -179,7 +179,7 @@ function parseDenoSpecifier(
return { type: +match[1], specifier };
}

function getDenoType(type: string): RequestedModuleType {
function getDenoType(id: string, type: string): RequestedModuleType {
switch (type) {
case "json":
return RequestedModuleType.Json;
Expand All @@ -188,6 +188,9 @@ function getDenoType(type: string): RequestedModuleType {
case "text":
return RequestedModuleType.Text;
default:
if (id.endsWith(".json")) {
return RequestedModuleType.Json;
}
return RequestedModuleType.Default;
}
}
25 changes: 25 additions & 0 deletions packages/plugin-vite/tests/build_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,28 @@ Deno.test({
sanitizeOps: false,
sanitizeResources: false,
});

Deno.test({
name: "vite build - load json inside npm package",
fn: async () => {
await using res = await buildVite(DEMO_DIR);

await withChildProcessServer(
{
cwd: res.tmp,
args: ["serve", "-A", "--port", "0", "_fresh/server.js"],
},
async (address) => {
await withBrowser(async (page) => {
await page.goto(`${address}/tests/mime`, {
waitUntil: "networkidle2",
});

await page.locator(".ready").wait();
});
},
);
},
sanitizeOps: false,
sanitizeResources: false,
});
16 changes: 16 additions & 0 deletions packages/plugin-vite/tests/dev_server_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,19 @@ Deno.test({
sanitizeResources: false,
sanitizeOps: false,
});

Deno.test({
name: "vite dev - can import json in npm package",
fn: async () => {
await withDevServer(DEMO_DIR, async (address) => {
await withBrowser(async (page) => {
await page.goto(`${address}/tests/mime`, {
waitUntil: "networkidle2",
});
await page.locator(".ready").wait();
});
});
},
sanitizeResources: false,
sanitizeOps: false,
});
Loading