Skip to content

fix(vite): only transform js-like files in deno loader #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinhagemeister merged 1 commit into from
Aug 21, 2025
+37 −2
Merged

fix(vite): only transform js-like files in deno loader #3234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions packages/plugin-vite/src/plugins/deno.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { Plugin } from "vite";
import {
type Loader,
MediaType,
RequestedModuleType,
ResolutionMode,
Workspace,
Expand Down Expand Up @@ -140,6 +141,7 @@ export function deno(): Plugin {

const maybeJsx = babelTransform({
ssr: !!options?.ssr,
media: result.mediaType,
code,
id: specifier,
isDev,
Expand Down Expand Up @@ -183,6 +185,7 @@ export function deno(): Plugin {

const maybeJsx = babelTransform({
ssr: !!options?.ssr,
media: result.mediaType,
id,
code,
isDev,
Expand Down Expand Up @@ -233,6 +236,32 @@ export function deno(): Plugin {
};
}

function isJsMediaType(media: MediaType): boolean {
switch (media) {
case MediaType.JavaScript:
case MediaType.Jsx:
case MediaType.Mjs:
case MediaType.Cjs:
case MediaType.TypeScript:
case MediaType.Mts:
case MediaType.Cts:
case MediaType.Tsx:
return true;

case MediaType.Dts:
case MediaType.Dmts:
case MediaType.Dcts:
case MediaType.Css:
case MediaType.Json:
case MediaType.Html:
case MediaType.Sql:
case MediaType.Wasm:
case MediaType.SourceMap:
case MediaType.Unknown:
return false;
}
}

export type DenoSpecifier = string & { __deno: string };

function isDenoSpecifier(str: unknown): str is DenoSpecifier {
Expand Down Expand Up @@ -286,10 +315,16 @@ function getDenoType(id: string, type: string): RequestedModuleType {
}

function babelTransform(
options: { ssr: boolean; code: string; id: string; isDev: boolean },
options: {
media: MediaType;
ssr: boolean;
code: string;
id: string;
isDev: boolean;
},
) {
if (
!/\.([tj]sx?|[mc[jt]s)$/.test(options.id) &&
!isJsMediaType(options.media) &&
!/^https?:\/\//.test(options.id)
) {
return null;
Expand Down
Loading