Skip to content

feat: benchmark workers #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 164 commits into from
Apr 26, 2025
Merged

feat: benchmark workers #1101

merged 164 commits into from
Apr 26, 2025

Conversation

fribbels
Copy link
Owner

@fribbels fribbels commented Apr 1, 2025

Pull Request

Description

Goals:

  • Async dps score components
  • Refactor stat simulations
  • Refactor benchmark generation
  • Add new benchmark worker
  • Add new DPS score
  • Caching
  • Custom benchmark tool
  • Add unit tests for stat sims
  • Add unit tests for benchmark generators
  • Generalize benchmark set selection

TODOs:

  • Fix scoringType enum
  • Fix transformWorkerContext
  • Fix const value = sim.simType == StatSimTypes.SubstatRolls
  • Fix Button onClick={generateCustomBenchmark
  • Fix simResult: optimizerDisplayData
  • Fix calculateConditionals commented out
  • Fix isFirefox
  • Fix calculateBuild still being used
  • Fix internal: boolean = false, // TODO: Remove
  • Fix !== 'NONE' main stat type
  • Fix character score display
  • Fix benchmarks tab #hash
  • Fix .filter((x) => x != -1)
  • Fix in-worker object cloning
  • Fix portrait unblurring delay
  • Fix src/lib/worker/computeOptimalSimulationWorkerRunner.ts
  • Fix remove weight
  • Fix character preview double refresh
  • Fix worker typing
  • Fix combat stats async display
  • Fix /new/ directory

Cleanup:

  • Fix poolSize
  • Fix .debugs
  • Fix defaultForm: Partial

Followups:

  • Fix substat roll count guessing
  • Solve local maxima issue
  • CharacterPreview store

image

Related Issue

Checklist

  • I have added commit messages that are descriptive and meaningful.
  • I have tested the changes locally.
  • I have reviewed the code changes.

Screenshots

@fribbels fribbels marked this pull request as ready for review April 24, 2025 03:15
@fribbels fribbels changed the title draft: WIP benchmark workers feat: benchmark workers Apr 24, 2025
@fribbels fribbels merged commit 9536af3 into beta Apr 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant