Skip to content

feat: initial streaming / live import support #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 28 commits into
base: beta
Choose a base branch
from

Conversation

emmachase
Copy link
Contributor

@emmachase emmachase commented Apr 16, 2025

Pull Request

Description

TODO:

  • Add a proper UI for toggling live import state / managing options
    • Add translation keys for new UI strings (currently since I haven't settled on a UI I'm just hard-coding for now)
  • Merge/refactor some of the DB update code which got duplicated
  • Is there a better way to do the IDs / ageIndex? Currently I'm forcing ageIndex to be negative of the relic uid but this seems like a hack.
  • Add UIs that properly take advantage of the new live import capabilities.

Related Issue

N/A

Checklist

  • I have added commit messages that are descriptive and meaningful.
  • I have tested the changes locally.
  • I have reviewed the code changes.

Screenshots

- thundering herd fixed by patching partysocket to close while ws is in CONNECTING state (opened an upstream pr as well), for now we patch-package
- live unequipping (removed copied check from db import that only equipped new relics)
- live enhance now properly updates the relic card in the relics tab (it had a cached state of the selected relic)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant