126 replace variable collapse with gluecollapse - #132
Merged
peterdesmet merged 5 commits intoMar 27, 2023
Conversation
Member
Author
|
Ready for review |
peterdesmet
requested changes
Mar 22, 2023
peterdesmet
left a comment
Member
There was a problem hiding this comment.
This PR moves the variables to the glue() function. It does not use glue_collapse() though. Do you see a benefit in using this over paste()?
Member
|
E.g. could we use: assertthat::assert_that(
all(!is.na(field_names)),
msg = glue::glue(
"All fields in `schema` must have property `name`.",
"\u2139 Field(s) `{field_numbers}` don't have a name.",
.sep = "\n",
field_numbers = glue::glue_collapse(which(is.na(field_names)), "`, `")
)
) |
Member
Author
|
In this case I don't see a benefit, but not a real cost either. So we can certainly use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #126
Moves some objects that were only used for messaging inside glue syntax.