Add datapackage class, update create_package() and check_package() - #187
Merged
Conversation
- Don't double set `datapackage` - Return descriptor
datapackage class, make check_package() public and provide better error messagesdatapackage class, update create_package() and check_package()
…sdata/frictionless-r into tabular-data-package
Don't set `"profile"="tabular-data-package"` and remove it from example dataset
PietrH
requested changes
Mar 20, 2024
PietrH
left a comment
Member
There was a problem hiding this comment.
Tiny suggestions, nothing that needs to be changed per se.
Very nicely done, very clear and easy to review.
Co-authored-by: Pieter Huybrechts <48065851+PietrH@users.noreply.github.com>
Co-authored-by: Pieter Huybrechts <48065851+PietrH@users.noreply.github.com>
It updates the link to https://dplyr.tidyverse.org/reference/reexports.html, I find just code more meaningful
peterdesmet
commented
Mar 20, 2024
peterdesmet
left a comment
Member
Author
There was a problem hiding this comment.
@PietrH implemented most of the suggested changes. Can you review again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #184, #185
datapackageclass topackageand describe it throughout as a "Data Package object"create_package()to make it a Data Package object. Use it inread_package()check_package()at the end ofcreate_package()check_package()public and provide more meaningful error messages. Warn ifdatapackageclass is missing, so that packages using frictionless as a dependency don't break."profile"="tabular-data-package"and remove it from example dataset #188