Skip to content

Add datapackage class, update create_package() and check_package() - #187

Merged
peterdesmet merged 28 commits into
mainfrom
add_class
Mar 22, 2024
Merged

Add datapackage class, update create_package() and check_package()#187
peterdesmet merged 28 commits into
mainfrom
add_class

Conversation

@peterdesmet

@peterdesmet peterdesmet commented Mar 19, 2024

Copy link
Copy Markdown
Member

Fix #184, #185

  • Add datapackage class to package and describe it throughout as a "Data Package object"
  • Allow to provide an existing descriptor to create_package() to make it a Data Package object. Use it in read_package()
  • Always run a check_package() at the end of create_package()
  • Make check_package() public and provide more meaningful error messages. Warn if datapackage class is missing, so that packages using frictionless as a dependency don't break.
  • Don't set "profile"="tabular-data-package" and remove it from example dataset #188

@peterdesmet peterdesmet changed the title Add datapackage class, make check_package() public and provide better error messages Add datapackage class, update create_package() and check_package() Mar 19, 2024
@peterdesmet peterdesmet added this to the 1.1.0 milestone Mar 19, 2024

@PietrH PietrH left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestions, nothing that needs to be changed per se.

Very nicely done, very clear and easy to review.

  • I've found another #156 and fixed it. 4f228ac
  • Currently in the differences with datapackage.r section of the readme we mention the fact that datapackage.r outputs a Package object as a major difference. This is no longer true.

Comment thread R/read_package.R
Comment thread R/read_resource.R
Comment thread R/create_package.R
peterdesmet and others added 4 commits March 20, 2024 15:16
Co-authored-by: Pieter Huybrechts <48065851+PietrH@users.noreply.github.com>
Co-authored-by: Pieter Huybrechts <48065851+PietrH@users.noreply.github.com>
It updates the link to https://dplyr.tidyverse.org/reference/reexports.html, I find just code more meaningful
@peterdesmet
peterdesmet requested a review from PietrH March 20, 2024 15:17

@peterdesmet peterdesmet left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PietrH implemented most of the suggested changes. Can you review again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add class to package object

2 participants