Added improved error messages to the derive FromPyObject macro for ba… #1

batconjurer · 2021-05-27T13:43:31Z

…sic structs and enums

Thank you for contributing to pyo3!

Please consider adding the following to your pull request:

an entry in CHANGELOG.md
docs to all new functions and / or detail in the guide
tests for all new or changed functions

Be aware the CI pipeline will check your pull request for the following:

Rust tests (Just cargo test or make test if you need to test examples)
Rust lints (make clippy)
Rust formatting (cargo fmt)
Python formatting (black . --check. You can install black with pip install black)
Compatibility with all supported Python versions for all examples. This uses tox; you can do run it using make test_py.

You can run a similar set of checks as the CI pipeline using make test.

…sic structs and enums

… in FromPyObject::extract

…on tuples and newtype structs/tuples

Simplify code generated for for_each_method_def and for_each_proto_slot

Co-authored-by: Georg Brandl <[email protected]>

If we got more then one file, only take those that contain the arch name. For ubuntu 20.04 with host architecture x86_64 and a foreign architecture of armhf this reduces the number of candidates to 1: $ find /usr/lib/python3.8/ -name '_sysconfigdata*.py' -not -lname '*' /usr/lib/python3.8/_sysconfigdata__x86_64-linux-gnu.py /usr/lib/python3.8/_sysconfigdata__arm-linux-gnueabihf.py CHANGELOG.md: add entry for cross-sysconfigdata filter on arch commit changelog: 1. initial 2. if filtered list is empty, use pre filtered. 3. clippy is_empty and cloned

…ted work on TypeError message on Enums

bench: don't alert on CI benchmark changes

guide: bump mdbook to 0.4.10

…3#1693) * Rewrite `module.md` for clarity and add tip on code organization * Add section on how to build the guide + add workaround proposed by David * Make more clear references to PyO3#1709

) * Add support to IndexMap * Fix indexmap version to 1.6.2 * Remove code duplication by mistake * Fix ambiguity in test * Minor change for doc.rs * Add to lib.rs docstring * Add indexmap to conversion table * Add indexmap flag in docs.rs action * Add indexmap feature to CI * Add note in changelog * Use with_gil in tests * Move code to src/conversions/indexmap.rs * Add PR number to CHANGELOG Co-authored-by: David Hewitt <[email protected]> * Add round trip test * Fix issue in MSRV Ubuntu build * Fix Github workflow syntax * Yet Another Attempt to Fix MSRV Ubuntu build * Specify hashbrown to avoid ambiguity in CI * Add suggestions * More flexible version for indexmap * Add documentation * Address PR comments * Export indexmap for docs Co-authored-by: David Hewitt <[email protected]>

guide: add latest symlink

pypy: fix FFI definition of Py_Buffer

err: don't use with_gil internally in PyErr::new()

docs: use pyo3.rs/latest instead of pyo3.rs/main

testing: use `mod tests` instead of `mod test`

rust: updates for rust & clippy 1.54

readme: slightly improve getting started notes

pyo3-pytests: don't set profile in Cargo.toml

Co-authored-by: David Hewitt <[email protected]>

…ract_type_errors

…catenating all error messages

…emoved all unsafe code from macro generated code. Two other small fixes

batconjurer and others added 30 commits May 27, 2021 15:42

Added improved error messages to the derive FromPyObject macro for ba…

f68ab48

…sic structs and enums

Changed format of TypeError messages

d71d432

Added customizable conversion error message for type errors encounted…

8981b84

… in FromPyObject::extract

Added support for enhanced errors for the FromPyObject trait derived …

1843ff2

…on tuples and newtype structs/tuples

improve librs documentation

22d080e

discard trailing whitespace

21f79a2

Simplify code generated for for_each_method_def and for_each_proto_slot

030aa43

Method and slot visitors accept slices instead of individual items

1ba3217

Merge pull request PyO3#1641 from 1tgr/for-each

8bf3ade

Simplify code generated for for_each_method_def and for_each_proto_slot

Update src/lib.rs

ace6682

Co-authored-by: Georg Brandl <[email protected]>

Update src/lib.rs

1922e98

Co-authored-by: Georg Brandl <[email protected]>

Update src/lib.rs

435a2bd

Co-authored-by: Georg Brandl <[email protected]>

Update src/lib.rs

3228b30

Co-authored-by: Georg Brandl <[email protected]>

Update src/lib.rs

e8f4abe

Co-authored-by: Georg Brandl <[email protected]>

Update src/lib.rs

c13a1b0

Co-authored-by: Georg Brandl <[email protected]>

Update src/lib.rs

b703aa5

Co-authored-by: Georg Brandl <[email protected]>

add renaming method to guide

ce3b0d1

clarify multiple-pymethods' supported platforms

38642aa

removed trailing space

088ad61

Fixed tests after modifying TypeErrors originating from structs. Star…

4a99bfa

…ted work on TypeError message on Enums

move manual builds to its own header

d86559b

Merge pull request PyO3#1643 from mejrs/main

d680fbe

faq: add section about pyo3(get) cloning fields

161f1bd

Added detailed TypeError messages to enums with derive(FromPyOjbect)

1a8fec2

move num_bigint_impl to own module

bf23295

add faq doctest

63e6d66

mark non-rust code as text fields

e2cb176

mark toml field as toml

dbf9a91

Started adding more unit tests

dfc484c

messense and others added 30 commits July 20, 2021 08:40

Merge pull request PyO3#1732 from davidhewitt/no-bench-alert

7957521

bench: don't alert on CI benchmark changes

guide: bump mdbook to 0.4.10

6e0fb9e

Merge pull request PyO3#1735 from davidhewitt/mdbook-0.4.10

f72a965

guide: bump mdbook to 0.4.10

guide: add latest symlink

fccea9f

Rewrite module.md for clarity and add tip on code organization (PyO…

9ab7b1f

…3#1693) * Rewrite `module.md` for clarity and add tip on code organization * Add section on how to build the guide + add workaround proposed by David * Make more clear references to PyO3#1709

pypy: fix FFI definition of Py_Buffer

d46d326

Merge pull request PyO3#1734 from davidhewitt/latest-tag

243e5ee

guide: add latest symlink

docs: use pyo3.rs/latest instead of pyo3.rs/main

3794aab

benches: add bench_err

dc58815

err: don't use with_gil internally in PyErr::new()

c09947a

Merge pull request PyO3#1737 from davidhewitt/pypy-buffer

1a0f46b

pypy: fix FFI definition of Py_Buffer

Merge pull request PyO3#1724 from davidhewitt/err-new-no-gil

4a71f82

err: don't use with_gil internally in PyErr::new()

Merge pull request PyO3#1738 from davidhewitt/latest-links

bbe0e84

docs: use pyo3.rs/latest instead of pyo3.rs/main

testing: use mod tests instead of mod test

a7244b8

Merge pull request PyO3#1740 from davidhewitt/mod-tests

3241467

testing: use `mod tests` instead of `mod test`

rust: updates for rust & clippy 1.54

ee9a167

dev-deps: pin criterion to 0.3.4

16e6f78

pycell: fix calculation of dictoffset on 32-bit Windows

4c5aee9

Merge pull request PyO3#1745 from davidhewitt/rust-1.54

e6d750a

rust: updates for rust & clippy 1.54

readme: slightly improve getting started notes

13f8953

Merge pull request PyO3#1743 from davidhewitt/improve-readme

fb744e1

readme: slightly improve getting started notes

pyo3-pytests: don't set profile in Cargo.toml

ba0ba14

Merge pull request PyO3#1744 from davidhewitt/no-profile

8e7737d

pyo3-pytests: don't set profile in Cargo.toml

Update pyo3-macros-backend/src/from_pyobject.rs

363383e

Co-authored-by: David Hewitt <[email protected]>

Small refactor

a42447b

Merge branch 'main' of https://github.com/PyO3/pyo3 into enhanced_ext…

403d882

…ract_type_errors

Reworked struct error messages to use the of an error rather than con…

3cfc76a

…catenating all error messages

Refactored to prevent re-acquiring the gil

5b8efdd

Replaced require_gil with Python::with_gil in test_frompyobject.rs. R…

d809e50

…emoved all unsafe code from macro generated code. Two other small fixes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added improved error messages to the derive FromPyObject macro for ba… #1

Added improved error messages to the derive FromPyObject macro for ba… #1

Uh oh!

batconjurer commented May 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Added improved error messages to the derive FromPyObject macro for ba… #1

Are you sure you want to change the base?

Added improved error messages to the derive FromPyObject macro for ba… #1

Uh oh!

Conversation

batconjurer commented May 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants