Add compatibility with PhpSpec 8.* and PHP 8.4

[torchello]

Hey folks! Trying to get it compatible with https://github.com/phpspec/phpspec/releases/tag/8.0.0. Is this enough?

[jaylinski]

I already started with it in #12.

What about phpspec/phpspec#1477? It seems not to be done yet. 🤔

[torchello]

It's done and closed today!

[torchello]

@jaylinski Should I close this PR in favor of #12?

Unrelated question – how about forking https://github.com/ciaranmcnulty/phpspec-typehintedmethods to https://github.com/friends-of-phpspec ? I maintain my own fork, but I think it's a nice extension to keep supporting.

[jaylinski]

Unrelated question – how about forking https://github.com/ciaranmcnulty/phpspec-typehintedmethods to https://github.com/friends-of-phpspec ? I maintain my own fork, but I think it's a nice extension to keep supporting.

I'd be open to add the package to our org. @shulard what do you think?

[shulard]

I agree, we can add this library in our org. @torchello this means we'll publish the package with a new prefix on packagist then you can still maintain the repository and help us with this one 😄.

[torchello]

Sure, thanks!

[jaylinski]

@torchello I forked your fork and added you to the repository: https://github.com/friends-of-phpspec/phpspec-typehintedmethods

@shulard Can you add @torchello to our org too? (I don't have the permissions for that.)

[jaylinski]

@jaylinski Should I close this PR in favor of #12?

@torchello Yes, please close this PR. I added your changes in #12 and already created a release. Thank you!

[shulard]

@shulard Can you add @torchello to our org too? (I don't have the permissions for that.)

Yep I've invited @torchello in the org and I also tweaked the permissions. Let me know if you still have trouble accessing some of the features.

So I close this PR in favor of #12

[shulard]

@torchello can you also enable commit signing in your profile ? Here is the documentation: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

[torchello]

@shulard What steps are needed to publish https://github.com/friends-of-phpspec/phpspec-typehintedmethods to composer?

[shulard]

@shulard What steps are needed to publish https://github.com/friends-of-phpspec/phpspec-typehintedmethods to composer?

We need to submit the package on packagist. I can do that however I get an error when I try:

A package with the name ciaranmcnulty/phpspec-typehintedmethods already exists. You should update the name property in your composer.json file.

The vendor name "ciaranmcnulty" was already claimed by someone else on Packagist.org. You may ask them to add your package and give you maintainership access. If they add you as a maintainer on any package in that vendor namespace, you will then be able to add new packages in that namespace. The packages already in that vendor namespace can be found at ciaranmcnulty.If those packages belong to you but were submitted by someone else, you can contact us to resolve the issue.

Can you check that ? Maybe we need to change the name ?

[jaylinski]

Yes, you need to change the name to friends-of-phpspec/phpspec-typehintedmethods here:
https://github.com/friends-of-phpspec/phpspec-typehintedmethods/blob/191fbe237cd80ca3f6b81da7a8b2cc8e940899ed/composer.json#L2

[torchello]

Yeah, will do!

[torchello]

friends-of-phpspec/phpspec-typehintedmethods#1