Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) in Async Message Queues - #84

Open
frkr wants to merge 2 commits into
mainfrom
sentinel-ssrf-mitigation-mq-9238220874226673192
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) in Async Message Queues#84
frkr wants to merge 2 commits into
mainfrom
sentinel-ssrf-mitigation-mq-9238220874226673192

Conversation

@frkr

@frkr frkr commented Jul 16, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Server-Side Request Forgery (SSRF) could occur if a malicious or malformed destiny or callback URL (e.g., using protocols like file:// or ftp://) were placed into a message, which would then be fetched by the background worker processes in MQDestiny.ts and MQCallback.ts.
🎯 Impact: An attacker could potentially coerce the Cloudflare Worker into probing internal resources, fetching unintended local files/network resources, or exploiting vulnerabilities in internal endpoints.
πŸ”§ Fix: Added strict protocol validation (http: or https:) using the standard new URL(urlString) constructor in both MQDestiny.ts and MQCallback.ts. If an unauthorized protocol is supplied, the message is gracefully flagged with an error status in the MQStore and processing is aborted without retrying.
βœ… Verification: Ran pnpm run test and successfully verified that all 55 existing tests continue to pass. The fix has no unintended side effects on normal operations while significantly mitigating SSRF risks.


PR created automatically by Jules for task 9238220874226673192 started by @frkr

Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant