π‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) in Async Message Queues - #84
π‘οΈ Sentinel: [HIGH] Fix Server-Side Request Forgery (SSRF) in Async Message Queues#84frkr wants to merge 2 commits into
Conversation
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: Server-Side Request Forgery (SSRF) could occur if a malicious or malformed
destinyorcallbackURL (e.g., using protocols likefile://orftp://) were placed into a message, which would then be fetched by the background worker processes inMQDestiny.tsandMQCallback.ts.π― Impact: An attacker could potentially coerce the Cloudflare Worker into probing internal resources, fetching unintended local files/network resources, or exploiting vulnerabilities in internal endpoints.
π§ Fix: Added strict protocol validation (
http:orhttps:) using the standardnew URL(urlString)constructor in bothMQDestiny.tsandMQCallback.ts. If an unauthorized protocol is supplied, the message is gracefully flagged with anerrorstatus in theMQStoreand processing is aborted without retrying.β Verification: Ran
pnpm run testand successfully verified that all 55 existing tests continue to pass. The fix has no unintended side effects on normal operations while significantly mitigating SSRF risks.PR created automatically by Jules for task 9238220874226673192 started by @frkr