Skip to content

🛡️ Sentinel: [CRITICAL] Fix SSRF in background workers - #86

Open
frkr wants to merge 3 commits into
mainfrom
jules-14747614525031795322-982e7adb
Open

🛡️ Sentinel: [CRITICAL] Fix SSRF in background workers#86
frkr wants to merge 3 commits into
mainfrom
jules-14747614525031795322-982e7adb

Conversation

@frkr

@frkr frkr commented Jul 30, 2026

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
💡 Vulnerability: The background queue processors (MQDestiny.ts and MQCallback.ts) did not validate the protocol of user-hydrated or externally supplied URLs before making outbound fetch requests.
🎯 Impact: This lack of validation could allow Server-Side Request Forgery (SSRF). An attacker could exploit this by crafting payloads with file:, javascript:, or data: protocols, forcing the server to read local files or make arbitrary internal requests, potentially bypassing security policies.
🔧 Fix: Parsed the destination and callback URLs using the URL object and enforced a strict check to ensure their protocol is either http: or https:. If an invalid or malicious protocol is detected, the URL is rejected and the message is safely logged as 'error' in MQStore, returning early to halt execution without throwing an unhandled exception or leaking information.
✅ Verification: Ensure the test suite continues to pass (pnpm test). The fetch function will no longer execute for non-HTTP(S) URLs in background processes.


PR created automatically by Jules for task 14747614525031795322 started by @frkr

…background processors

Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 2 commits July 30, 2026 08:37
…background processors

Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
…background processors

Co-authored-by: frkr <185359+frkr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant