Skip to content

Removed id and pkgd.min file #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Geet06 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed id and pkgd.min file #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/amd/froala-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
define(['exports', 'aurelia-framework', 'aurelia-binding', './froala-editor-config', 'froala-editor/js/froala_editor.pkgd.min.js'], function (exports, _aureliaFramework, _aureliaBinding, _froalaEditorConfig, _froala_editorPkgdMin) {
define(['exports', 'aurelia-framework', 'aurelia-binding', './froala-editor-config', 'froala-editor/js/froala_editor.min.js'], function (exports, _aureliaFramework, _aureliaBinding, _froalaEditorConfig, _froala_editorMin) {
'use strict';

Object.defineProperty(exports, "__esModule", {
value: true
});
exports.FroalaEditor1 = undefined;

var _froala_editorPkgdMin2 = _interopRequireDefault(_froala_editorPkgdMin);
var _froala_editorMin2 = _interopRequireDefault(_froala_editorMin);

function _interopRequireDefault(obj) {
return obj && obj.__esModule ? obj : {
Expand Down Expand Up @@ -123,7 +123,7 @@ define(['exports', 'aurelia-framework', 'aurelia-binding', './froala-editor-conf
return _this2.value = editor.html.get();
});

this.instance = new _froala_editorPkgdMin2.default('#' + this.element.id, Object.assign({}, this.config));
this.instance = new _froala_editorMin2.default(this.element, Object.assign({}, this.config));
};

FroalaEditor1.prototype.tearDown = function tearDown() {
Expand Down
6 changes: 3 additions & 3 deletions dist/commonjs/froala-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ var _aureliaBinding = require('aurelia-binding');

var _froalaEditorConfig = require('./froala-editor-config');

var _froala_editorPkgdMin = require('froala-editor/js/froala_editor.pkgd.min.js');
var _froala_editorMin = require('froala-editor/js/froala_editor.min.js');

var _froala_editorPkgdMin2 = _interopRequireDefault(_froala_editorPkgdMin);
var _froala_editorMin2 = _interopRequireDefault(_froala_editorMin);

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }

Expand Down Expand Up @@ -122,7 +122,7 @@ var FroalaEditor1 = exports.FroalaEditor1 = (_dec = (0, _aureliaFramework.custom
return _this2.value = editor.html.get();
});

this.instance = new _froala_editorPkgdMin2.default('#' + this.element.id, Object.assign({}, this.config));
this.instance = new _froala_editorMin2.default(this.element, Object.assign({}, this.config));
};

FroalaEditor1.prototype.tearDown = function tearDown() {
Expand Down
4 changes: 2 additions & 2 deletions dist/es2015/froala-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import { ObserverLocator } from "aurelia-binding";

import { Config } from './froala-editor-config';

import FroalaEditor from 'froala-editor/js/froala_editor.pkgd.min.js';
import FroalaEditor from 'froala-editor/js/froala_editor.min.js';

export let FroalaEditor1 = (_dec = customElement('froala-editor'), _dec2 = inject(Element, Config, ObserverLocator), _dec(_class = _dec2(_class = (_class2 = class FroalaEditor1 {

Expand Down Expand Up @@ -95,7 +95,7 @@ export let FroalaEditor1 = (_dec = customElement('froala-editor'), _dec2 = injec
this.instance.addEventListener('contentChanged', (e, editor) => this.value = editor.html.get());
this.instance.addEventListener('blur', (e, editor) => this.value = editor.html.get());

this.instance = new FroalaEditor(`#${this.element.id}`, Object.assign({}, this.config));
this.instance = new FroalaEditor(this.element, Object.assign({}, this.config));
}

tearDown() {
Expand Down
8 changes: 4 additions & 4 deletions dist/system/froala-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

System.register(['aurelia-framework', 'aurelia-binding', './froala-editor-config', 'froala-editor/js/froala_editor.pkgd.min.js'], function (_export, _context) {
System.register(['aurelia-framework', 'aurelia-binding', './froala-editor-config', 'froala-editor/js/froala_editor.min.js'], function (_export, _context) {
"use strict";

var inject, customElement, bindable, ObserverLocator, Config, FroalaEditor, _dec, _dec2, _class, _desc, _value, _class2, _descriptor, _descriptor2, _descriptor3, FroalaEditor1;
Expand Down Expand Up @@ -63,8 +63,8 @@ System.register(['aurelia-framework', 'aurelia-binding', './froala-editor-config
ObserverLocator = _aureliaBinding.ObserverLocator;
}, function (_froalaEditorConfig) {
Config = _froalaEditorConfig.Config;
}, function (_froalaEditorJsFroala_editorPkgdMinJs) {
FroalaEditor = _froalaEditorJsFroala_editorPkgdMinJs.default;
}, function (_froalaEditorJsFroala_editorMinJs) {
FroalaEditor = _froalaEditorJsFroala_editorMinJs.default;
}],
execute: function () {
_export('FroalaEditor1', FroalaEditor1 = (_dec = customElement('froala-editor'), _dec2 = inject(Element, Config, ObserverLocator), _dec(_class = _dec2(_class = (_class2 = function () {
Expand Down Expand Up @@ -125,7 +125,7 @@ System.register(['aurelia-framework', 'aurelia-binding', './froala-editor-config
return _this2.value = editor.html.get();
});

this.instance = new FroalaEditor('#' + this.element.id, Object.assign({}, this.config));
this.instance = new FroalaEditor(this.element, Object.assign({}, this.config));
};

FroalaEditor1.prototype.tearDown = function tearDown() {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"babel-preset-stage-1": "^6.22.0",
"conventional-changelog": "^2.0.3",
"del": "^3.0.0",
"gulp": "^4.0.0",
"gulp": "^3.9.1",
"gulp-babel": "^6.1.2",
"gulp-bump": "^2.7.0",
"gulp-eslint": "^3.0.1",
Expand Down
4 changes: 2 additions & 2 deletions src/froala-editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {ObserverLocator} from "aurelia-binding";
import {Config} from './froala-editor-config';

// Import Froala Editor
import FroalaEditor from 'froala-editor/js/froala_editor.pkgd.min.js'
import FroalaEditor from 'froala-editor/js/froala_editor.min.js'
Copy link
Contributor

@navneetnagpal navneetnagpal May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geet06 import FroalaEditor from 'froala-editor'; we should use this instead of js file.


@customElement('froala-editor')
@inject(Element, Config, ObserverLocator)
Expand Down Expand Up @@ -68,7 +68,7 @@ export class FroalaEditor1 {
this.instance.addEventListener('blur', (e, editor) => this.value = editor.html.get())

// Initialize editor.
this.instance = new FroalaEditor(`#${this.element.id}`, Object.assign({}, this.config));
this.instance = new FroalaEditor(this.element, Object.assign({}, this.config));
}

// Destroy.
Expand Down