[pull] master from datacite:master#118
Merged
pull[bot] merged 1 commit intofront-matter:masterfrom Apr 8, 2026
Merged
Conversation
…ping (#1483) * Initial plan * Add affiliation-country filter with ROR mapping and Elasticsearch indexing Co-authored-by: ashwinisukale <1137325+ashwinisukale@users.noreply.github.com> * Refactor affiliation_countries to reduce duplication and improve tests Co-authored-by: ashwinisukale <1137325+ashwinisukale@users.noreply.github.com> * Fixed rubocop issues and added ror to country mapping json file * fix: normalize ROR_TO_COUNTRIES lookup key * Fix: we changed tests to be data-driven - For Rorable specs: expected countries are computed from ROR_TO_COUNTRIES[ror_url] (and then upcased/uniq), instead of hardcoding "US". - For the DOI affiliation_countries specs: expected countries are computed from the mapping for the RORs used, and deduplication is tested by asserting the result equals result.uniq (instead of counting "US"). * test got removed during conflict resolution, adding them back * Fixed lint errors * it was got added in conflict, it should be removed * Migrate get_countries_from_ror to RorReferenceStore; remove static JSON file Agent-Logs-Url: https://github.com/datacite/lupo/sessions/44b8398a-25a1-47b0-be7c-39bccda1d1b8 Co-authored-by: ashwinisukale <1137325+ashwinisukale@users.noreply.github.com> * Guard download_from_s3 against missing ROR_ANALYSIS_S3_BUCKET env var Agent-Logs-Url: https://github.com/datacite/lupo/sessions/d3419087-8a2f-4214-b7bb-a8499ee38bd4 Co-authored-by: ashwinisukale <1137325+ashwinisukale@users.noreply.github.com> --------- Co-authored-by: Ashwini Sukale <ashwini.sukale@datacite.org> Co-authored-by: ashwinisukale <1137325+ashwinisukale@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )