FR-22443 Enhance getSession function to require response object - #436
Merged
vladFrontegg merged 1 commit intoOct 23, 2025
Conversation
…nteggApiMiddleware to use the new signature
vladFrontegg
requested review from
MaxArnautFrontegg,
TomerFrontegg,
amirjaron,
aviadmizrachi,
frontegg-david,
mariavlasov and
raz-shlomo-frontegg
as code owners
October 22, 2025 17:21
raz-shlomo-frontegg
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
getSessionfunction to require an explicitres(response) parameter and clarifies its usage through improved documentation. The main goal is to ensure the function is used correctly in scenarios involving sequential redirects or multiple server-side executions.Key changes:
Session Handling Improvements:
getSessionfunction signature to require theresparameter explicitly, improving clarity and preventing misuse in complex server-side flows.getSessioninFronteggApiMiddleware.tsto pass bothreqandres, ensuring compatibility with the new function signature.Documentation:
getSessionexplaining the purpose of the parameters and whenresmust be provided, aiding future maintainability and correct usage.Note
Make
getSessionrequire an explicitresparameter, add JSDoc, and update middleware to passreqandres.packages/nextjs/src/pages/helpers.ts):getSession(req, res)to requireres(no longer optional) and add detailed JSDoc.packages/nextjs/src/middleware/FronteggApiMiddleware.ts):getSession(req, res)when secure JWT is enabled to setauthorizationheader from session token.Written by Cursor Bugbot for commit ecbd358. This will update automatically on new commits. Configure here.