Added missing overrides - #117
Open
mgerhardy wants to merge 1 commit into
Open
Conversation
Owner
|
Why is it that it wants override in these cases, and not in all the other hundreds of places i override virtual methods? |
mgerhardy
force-pushed
the
pr/overrides
branch
from
December 12, 2016 07:48
3648315 to
d66c83e
Compare
Contributor
Author
|
updated the pr manually. For me there are no warnings for -Winconsistent-missing-override when including turbobadger headers in my project. But it is possible that there are still warnings left if you compile turbobadger itself (I'm using different compiler flags for external code). |
Contributor
Author
|
Looks like the tb namespace fix made it into this pr.. it should not be a problem because it's in master anyway already - if it is, let me know, then I will rebase this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
used clang-tidy